WordPress.org
Get WordPress

Making WordPress.org

Opened 10 years ago

Closed 10 years ago

#1857 closed defect (bug) (fixed)

Plugin Handbook: Invalid markup for sidebar widgets

Reported by: ocean90's profile ocean90 Owned by: coffee2code's profile coffee2code
Milestone: Priority: normal
Component: Developer Hub Keywords: has-patch
Cc:

Description

The sidebar on ​https://developer.wordpress.org/plugins/ is using <ul> as a wrapper for widgets. But a widget is wrapped with an <aside> tag since [3686] which breaks the layout.

Attachments (4)

1857.png​ (89.5 KB) - added by ocean90 10 years ago.
meta-1857.patch​ (2.2 KB) - added by SergeyBiryukov 10 years ago.
meta-1857.after.png​ (35.7 KB) - added by SergeyBiryukov 10 years ago.
meta-1857.2.patch​ (3.1 KB) - added by SergeyBiryukov 10 years ago.

Download all attachments as: .zip

Change History (9)

@ocean90
10 years ago

@SergeyBiryukov
10 years ago

#1 @SergeyBiryukov
10 years ago

  • Keywords has-patch added; needs-patch removed

@SergeyBiryukov
10 years ago

#2 @SergeyBiryukov
10 years ago

Screenshot with the patch: meta-1857.after.png​.

#3 follow-up: @ocean90
10 years ago

@SergeyBiryukov The CSS change looks good, but it's still invalid HTML.

@SergeyBiryukov
10 years ago

#4 in reply to: ↑ 3 @SergeyBiryukov
10 years ago

@ocean90: Forgot to include the <ul> removal in the previous patch, see meta-1857.2.patch​ :)

#5 @coffee2code
10 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 3722:

developer.wordpress.org: Fix sidebar display after changes to handbook sidebar markup in [3686].

Props SergeyBiryukov.
Fixes #1857.

Note: See TracTickets for help on using tickets.