Opened 11 years ago

Closed 10 years ago

#187 closed enhancement (fixed)

make/Community p2 post categories

Reported by: iandunn's profile iandunn Owned by: otto42's profile Otto42
Milestone: Priority: normal
Component: Make (Get Involved) / P2 Keywords:


@jenmylo requested some p2 modifications for the make/Community blog.

  1. The ability to assign a category to a new p2 post
  2. Creating a category template with the new post form included
  3. Add room to the category template for an intro area above the blog posts
  4. New home page design


Attachments (9)

post-form-with-category-dropdown.png (24.5 KB) - added by iandunn 11 years ago.
home-page.png (883.7 KB) - added by iandunn 11 years ago.
category-page.png (831.0 KB) - added by iandunn 11 years ago.
category-page-2.png (210.9 KB) - added by iandunn 11 years ago.
Includes the category description
187-p2-new-post-categories.diff (4.1 KB) - added by iandunn 11 years ago.
187-wporg-p2.diff (10.5 KB) - added by iandunn 11 years ago.
187-p2-new-post-categories.2.diff (4.2 KB) - added by iandunn 11 years ago.
187-p2-new-post-categories.3.diff (415 bytes) - added by iandunn 11 years ago.
187-p2-new-post-categories.4.diff (5.3 KB) - added by iandunn 10 years ago.

Download all attachments as: .zip

Change History (24)

#1 @iandunn
11 years ago

  • Owner set to iandunn
  • Status changed from new to assigned

#1 is written. I started a discussion on our p2 about whether it should live in the Meta repo or the official plugin repo.

11 years ago

#2 @iandunn
11 years ago

@jenmylo, I attached some screenshots for your feedback.

  • post-form-with-category-dropdown.png​shows the category dropdown added to the new post form.
  • home-page.pngshows category links being displayed on posts
  • category-page.png shows the category template with the post form added.

(The last two don't have the dropdown in them, but they will in production.)

Those are all ready to go, pending any tweaks you want and the decision on where to host the p2 category plugin.

I'll probably need a rough wireframe for #3 and #4, or at least a detailed description of what you want it to look like.

#3 @jenmylo
11 years ago

  1. Category dropdown and tag input could be on same line, the tag field doesn't need to be so long.
  1. Okay.
  1. Guessing that if there was a category description stored it would show above the list of posts?

#4 @iandunn
11 years ago

  1. P2 only has a hook to add elements at the end of the form, so I think the only way to get it there would be with absolute CSS positioning, or using Javascript to move it within the DOM after the fact. Both of those would be pretty fragile, though, so I'd recommend against it.
  2. Attached a new screenshot with that. P2 doesn't display tag descriptions; do you want them added on the tag archive template too?

11 years ago

Includes the category description

#5 @iandunn
11 years ago

187-p2-new-post-categories.diff​ is for the p2 plugin. I put it in a new folder in the Meta repo, so we can make it an svn:external in the private repo, similar to the handbook plugin.

187-wporg-p2.diff is for supporting the use of categories on the make/Community site.

Those two patches take care of #1 and #2. Waiting on wireframes to do #3 and #4.

#6 @iandunn
11 years ago

187-p2-new-post-categories.2.diff​ shows empty categories in the dropdown list and sorts the categories by name instead of ID.

#7 @Otto42
11 years ago

  • Owner changed from iandunn to Otto42
  • Status changed from assigned to reviewing

#8 @Otto42
11 years ago

In 109:

P2 Post Categories plugin and theme mods for make-community. See #187. props iandunn

#9 @Otto42
11 years ago

Okay, it's on there and activated for make/community, but you might want to have the dropdown have some kind of better default selection. Perhaps "Uncategorized".

#10 @iandunn
11 years ago

187-p2-new-post-categories.3.diff​ makes the default category selected by default.

#11 @Otto42
11 years ago

In 110:

Set default category in dropdown. see #187

#12 @Otto42
10 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

Closing this for now. Re-open if there are further changes to be made.

#13 @iandunn
10 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

187-p2-new-post-categories.4.diff​ takes advantage of the new p2_new_post_submit_success trigger in P2 to hook into the save-new-post process in a clean way. We don't have to hijack the Tag field anymore, so it's less confusing/disruptive for users.

#14 @Otto42
10 years ago

In 118:

New version of p2 plugin for make/community. props iandunn. see #187

#15 @Otto42
10 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.