WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 3 years ago

#1899 closed defect (fixed)

Closed topics are no longer marked as such in the title

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: Priority: normal
Component: Support Forums Keywords: has-patch commit has-screenshots
Cc:

Description

Previously, on support forums, titles of closed topics were prepended with [closed].

After the upgrade to bbPress 2.x in #1544, there's no way to recognize a closed topic before clicking on it.

If you do click on it, it's still not immediately obvious, because if you're an administrator, you still see the reply form.

The only evidence is "This topic is marked as closed to new replies, however your posting capabilities still allow you to do so." message above the form, which is easy to miss.

Attachments (10)

1899.diff (2.1 KB) - added by netweb 3 years ago.
1899.2.diff (6.3 KB) - added by SergeyBiryukov 3 years ago.
meta-1899.png (35.0 KB) - added by SergeyBiryukov 3 years ago.
meta-1899.after.png (35.3 KB) - added by SergeyBiryukov 3 years ago.
meta-1899.normal.png (28.9 KB) - added by SergeyBiryukov 3 years ago.
meta-1899.closed.png (29.7 KB) - added by SergeyBiryukov 3 years ago.
meta-1899.closed-resolved.png (32.3 KB) - added by SergeyBiryukov 3 years ago.
meta-1899.closed-resolved-sticky.png (33.8 KB) - added by SergeyBiryukov 3 years ago.
meta-1899.closed-sticky.png (31.2 KB) - added by SergeyBiryukov 3 years ago.
meta-1899.sticky.png (29.7 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (17)

@netweb
3 years ago

#1 @netweb
3 years ago

  • Keywords has-patch added

Added a plugin that prefixes closed topics with [Closed]

#2 @ocean90
3 years ago

  • Component changed from International Forums to Support Forums

This ticket was mentioned in Slack in #forums by sergey. View the logs.


3 years ago

#4 follow-up: @SergeyBiryukov
3 years ago

  • Keywords needs-patch added; has-patch removed

The "[Resolved]" indicator was recently converted to a checkmark in #2359.

For closed topics, I guess we could have a lock icon (which is what, as I vaguely recall, we had in the bbPress 1.x theme).

#5 in reply to: ↑ 4 @samuelsidler
3 years ago

Replying to SergeyBiryukov:

For closed topics, I guess we could have a lock icon (which is what, as I vaguely recall, we had in the bbPress 1.x theme).

That sounds good to me, we should just take care to consider what it looks like when they're two icons: a lock and a checkmark. What should the ordering be? I'd say the lock should definitely be grey though. #bikeshed

#6 @SergeyBiryukov
3 years ago

  • Keywords has-patch commit has-screenshots added; needs-patch removed

Here's how the list of topics with different statuses currently looks: meta-1899.png

Here's how it looks with 1899.2.diff: meta-1899.after.png.

Individual topics, with the patch:

Closed sticky topics are already marked with a grey icon color, I don't think we need a second (or a third, if it's also resolved) icon there. So the sticky icon supersedes the lock icon, and I guess it makes sense :)

#7 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 4993:

Support Theme: Prepend titles of closed topics with a lock dashicon in topic listings.

Also add a lock dashicon for closed topics in single topic views.

Fixes #1899.

Note: See TracTickets for help on using tickets.