Hardcoded strings in WordCamp.org plugin camptix-attendance

[kossmann]

There are two hardcoded strings making it impossible to translate.

[iandunn]

Hi Daniel, thanks for the patch!

This looks pretty good to me. The only minor things I'd change would be to use the wordcamporg text domain instead of camptix, and to always use the escaping translate functions (like esc_html__).

CampTix has it's own text domain because it's distributed in the WordPress.org repository, but the add-ons in the Meta repository should all use wordcamporg, so that they'll be included in our single GlotPress project.

Not everyone agrees with this, but personally I consider it a best practice to always use the escaping translate functions, to avoid any situations where malicious HTML is inserted into localized strings.

[kossmann]

Thanks for the feedback, here are the changes.

[kossmann]

v2

[kossmann]

Hi, is everything OK with my changes? Should I do something else?

[SergeyBiryukov]

I think <strong>Note</strong>: Anyone with the secret link can access the attendance UI... should be a single string rather than two separate strings (Note: and Anyone with the secret link...).

Looks good to me otherwise.

[kossmann]

v3

[kossmann]

Done!

[iandunn]

It looks like Note isn't a separate string in 3.diff, but I can make that change when I commit it. The rest looks good to me.

[iandunn]

Er, nevermind, I misread Sergey's comment. 3.diff is correct.

[SergeyBiryukov]

1903.3.diff​ makes the whole string bold, I didn't mean that :)

I just meant the string can be wrapped with esc_html_e() as is, no need to separate it. Occasional HTML tags in translatable strings are fine, unless thay wrap the whole string or placeholders (e.g. <code>%s</code>), in which case they can be moved out of the string.

[iandunn]

In 4968:

CampTix Attendance: Internationalize strings

Fixes #1903
Props kossmann, SergeyBiryukov

[SergeyBiryukov]

Reopening to address comment:5 and comment:9 in 1903.4.diff​.

Only the "Note" word should be bold, not the whole string. (Unless it was an intended change?)

[coreymckrill]

I think having the whole string bolded is ok. At this point if we change it back, the whole string will have to get translated again.