WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 3 years ago

#1924 closed defect (fixed)

Restore vertical scrolling for large code samples on support forums

Reported by: SergeyBiryukov Owned by: netweb
Milestone: Priority: normal
Component: International Forums Keywords: has-patch
Cc:

Description (last modified by SergeyBiryukov)

Previously, large code samples on support forums had both horizontal and vertical scrolling. (We do recommend using Pastebin or similar services for large samples, but most users still just paste them on the forums as is.)

After the upgrade to bbPress 2.x, the samples have horizontal scrolling, but the height is not limited, which makes it harder to browse the thread.

Adding max-height for the <code> element should fix it:

#bbpress-forums div.bbp-reply-content pre code,
#bbpress-forums div.bbp-topic-content pre code {
	max-height: 40em;
}

Attachments (2)

meta-1924.patch (609 bytes) - added by SergeyBiryukov 3 years ago.
1924-bb.diff (552 bytes) - added by netweb 3 years ago.

Download all attachments as: .zip

Change History (8)

#1 @SergeyBiryukov
3 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
3 years ago

  • Description modified (diff)

This ticket was mentioned in Slack in #buddypress by netweb. View the logs.


3 years ago

@netweb
3 years ago

#4 @netweb
3 years ago

I've asked in #BuddyPress if they'd like to see this change on https://buddypress.org/support, I think it is a great improvement, to that end 1924-bb.diff would implement the fix network wide for all instances of bbPress 2.x forums on w.org networks using the bb-base theme.

Screenshot https://cloudup.com/cnryZ6oyENm

Last edited 3 years ago by netweb (previous) (diff)

#5 @DJPaul
3 years ago

👍

Last edited 3 years ago by DJPaul (previous) (diff)

#6 @netweb
3 years ago

  • Owner set to netweb
  • Resolution set to fixed
  • Status changed from new to closed

In 3839:

BuddyPress.org: Add max-height for bbPress' bb-base themes topics and replies <code> code blocks.

Props SergeyBiryukov.
Fixes #1924.

Note: See TracTickets for help on using tickets.