#1928 closed enhancement (fixed)
Underscores not appearing in SyntaxHighlighter
Reported by: | hardeepasrani | Owned by: | coffee2code |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Developer Hub | Keywords: | has-patch has-screenshots dev-feedback |
Cc: |
Description
Example: https://developer.wordpress.org/themes/functionality/custom-headers/
Using Firefox, the underscores aren't appearing in the last line inside the syntax highlighter (screenshot attached). Adding a padding of 0.5rem makes it visible.
Attachments (2)
Change History (12)
This ticket was mentioned in Slack in #docs by hardeepasrani. View the logs.
8 years ago
#2
follow-up:
↓ 3
@
8 years ago
- Keywords has-patch has-screenshots dev-feedback added
- Type changed from defect to enhancement
Don't use !important unless it's really necessary. Use better selectors
#3
in reply to:
↑ 2
;
follow-up:
↓ 4
@
8 years ago
Replying to Kenshino:
Don't use !important unless it's really necessary. Use better selectors
Plugin's stylesheet is already using !important so better selectors won't do any good.
#4
in reply to:
↑ 3
@
8 years ago
Replying to hardeepasrani:
Replying to Kenshino:
Don't use !important unless it's really necessary. Use better selectors
Plugin's stylesheet is already using !important so better selectors won't do any good.
:(
This ticket was mentioned in Slack in #meta-devhub by drew. View the logs.
8 years ago
#6
@
8 years ago
Yeah, the highlighting library that my plugin uses has !important
to avoid being overridden by themes and such. This is one of the rare cases where it actually makes sense to use it (for the most part).
#7
@
8 years ago
- Owner set to coffee2code
- Resolution set to fixed
- Status changed from new to closed
In 3853:
Initial diff.