Context Navigation

← Previous Ticket
Next Ticket →

#1938 closed defect (bug) (fixed)

Correct translator comments in [wporg-plugin-upload] shortcode handler

Reported by:	SergeyBiryukov	Owned by:	dd32
Priority:	normal	Milestone:
Component:	Plugin Directory	Keywords:	has-patch commit
Cc:

Description (last modified by SergeyBiryukov)

There's an extra 2: style.css comment for some strings, but no such placeholder in the string itself. Appears to be a copy/paste from the Theme Directory.

Also, the extra %3$s placeholder duplicates an existing string for no reason.

Attachments (1)

meta-1938.patch (3.1 KB ) - added by SergeyBiryukov 10 years ago.

Download all attachments as: .zip

Change History (9)

@SergeyBiryukov
10 years ago

Attachment meta-1938.patch added

This ticket was mentioned in Slack in #polyglots by sergey. View the logs.

10 years ago

#2 follow-up: ↓ 4 @mobby2561
10 years ago

Would it be possible to put it together with this string?

https://translate.wordpress.org/projects/meta/plugins-v3/cs/default?filters[status]=either&filters[original_id]=2910740&filters[translation_id]=44842896
Now it's absolutely the same text.

Last edited 10 years ago by mobby2561 (previous) (diff)

#3 @SergeyBiryukov
10 years ago

Description modified (diff)

#4 in reply to: ↑ 2 ; follow-up: ↓ 5 @SergeyBiryukov
10 years ago

Replying to mobby2561:

Would it be possible to put it together with this string?

Yes, when the patch is committed, strings with the same text should automatically be merged.

#5 in reply to: ↑ 4 @mobby2561
10 years ago

Replying to SergeyBiryukov:

Replying to mobby2561:

Would it be possible to put it together with this string?

Yes, when the patch is committed, strings with the same text should automatically be merged.

Ok, thanks for the info.

#6 @SergeyBiryukov
10 years ago

Keywords commit added

#7 @SergeyBiryukov
10 years ago

@obenland, could you take a look?

#8 @dd32
10 years ago

Owner set to dd32
Resolution → fixed
Status new → closed

In 3984:

Plugin Directory: Correct the translator comments in the [wporg-plugin-upload] shortcode handler.

Props SergeyBiryukov.
Fixes #1938.

Note: See TracTickets for help on using tickets.

Download in other formats:

Making WordPress.org

Context Navigation

#1938 closed defect (bug) (fixed)

Correct translator comments in [wporg-plugin-upload] shortcode handler

Description (last modified by SergeyBiryukov)

Attachments (1)

Change History (9)

@SergeyBiryukov 10 years ago

This ticket was mentioned in ​Slack in #polyglots by sergey. ​View the logs. 10 years ago

#2 follow-up: ↓ 4 @mobby2561 10 years ago

#3 @SergeyBiryukov 10 years ago

#4 in reply to: ↑ 2 ; follow-up: ↓ 5 @SergeyBiryukov 10 years ago

#5 in reply to: ↑ 4 @mobby2561 10 years ago

#6 @SergeyBiryukov 10 years ago

#7 @SergeyBiryukov 10 years ago

#8 @dd32 10 years ago