WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 3 years ago

#1938 closed defect (fixed)

Correct translator comments in [wporg-plugin-upload] shortcode handler

Reported by: SergeyBiryukov Owned by: dd32
Milestone: Priority: normal
Component: Plugin Directory Keywords: has-patch commit
Cc:

Description (last modified by SergeyBiryukov)

There's an extra 2: style.css comment for some strings, but no such placeholder in the string itself. Appears to be a copy/paste from the Theme Directory.

Also, the extra %3$s placeholder duplicates an existing string for no reason.

Attachments (1)

meta-1938.patch (3.1 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (9)

This ticket was mentioned in Slack in #polyglots by sergey. View the logs.


3 years ago

#2 follow-up: @mobby2561
3 years ago

Last edited 3 years ago by mobby2561 (previous) (diff)

#3 @SergeyBiryukov
3 years ago

  • Description modified (diff)

#4 in reply to: ↑ 2 ; follow-up: @SergeyBiryukov
3 years ago

Replying to mobby2561:

Would it be possible to put it together with this string?

Yes, when the patch is committed, strings with the same text should automatically be merged.

#5 in reply to: ↑ 4 @mobby2561
3 years ago

Replying to SergeyBiryukov:

Replying to mobby2561:

Would it be possible to put it together with this string?

Yes, when the patch is committed, strings with the same text should automatically be merged.

Ok, thanks for the info.

#6 @SergeyBiryukov
3 years ago

  • Keywords commit added

#7 @SergeyBiryukov
3 years ago

@obenland, could you take a look?

#8 @dd32
3 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 3984:

Plugin Directory: Correct the translator comments in the [wporg-plugin-upload] shortcode handler.

Props SergeyBiryukov.
Fixes #1938.

Note: See TracTickets for help on using tickets.