WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 3 years ago

#1943 closed defect (invalid)

Improve translatable strings in WP.org Profiles Activity Handler

Reported by: SergeyBiryukov Owned by:
Milestone: Priority: normal
Component: Profiles Keywords: has-patch
Cc:

Description (last modified by SergeyBiryukov)

Let's fix a few translatable string issues in wporg-profiles-activity-handler.php:

  • Strings with placeholders should have translator comments.
  • Multiple placeholders should be numbered.
  • Extra HTML code that does not need to be translated should be removed.
  • Strings should be complete sentences, not a concatenation of separate phrases.

Attachments (1)

meta-1943.patch (9.5 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (4)

#1 @SergeyBiryukov
3 years ago

  • Description modified (diff)

#2 @SergeyBiryukov
3 years ago

  • Keywords commit added

#3 @coffee2code
3 years ago

  • Keywords commit removed
  • Resolution set to invalid
  • Status changed from new to closed

Thanks, @SergeyBiryukov!

However, after considering the strings, I ended up removing the ability for the strings to be translated in [3911].

All such strings were the activity action values (the strings that actually appear in the activity stream), which due to the design of BP's activity module, get stored in the database and not made dynamically, so translation is not appropriate.

Note: See TracTickets for help on using tickets.