Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#1949 closed defect (bug) (fixed)

Fix a typo and improve consistency in Profiles Activity Handler

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: coffee2code's profile coffee2code
Milestone: Priority: normal
Component: Profiles Keywords: has-patch commit


Some inconsistencies in WPOrg_Profiles_Activity_Handler::handle_wordcamp_activity():

  • The attendee_id branch uses string concatenation to append WordCamp date, whereas speaker_id and organizer_id branches above use separate strings for that.
  • coming up %s seems to be typo, should be coming up on %s, as in the speaker_id branch.

Attachments (1)

meta-1949.patch (1.8 KB) - added by SergeyBiryukov 8 years ago.

Download all attachments as: .zip

Change History (3)

#1 @coffee2code
8 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 3915:

Profiles Activity Handler: Improve WordCamp-related action strings.

  • Add "on".
  • For consistency, make attendee branch match string handling of the organizer branch.

Props SergeyBiryukov.
Fixes #1949.

#2 @SergeyBiryukov
8 years ago

  • Summary changed from Fix a typo in improve consistency in Profiles Activity Handler to Fix a typo and improve consistency in Profiles Activity Handler
Note: See TracTickets for help on using tickets.