WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 3 years ago

#1974 closed defect (fixed)

Forums: Breadcrumbs should be consistent

Reported by: SergeyBiryukov Owned by: coffee2code
Milestone: Priority: normal
Component: Support Forums Keywords: has-patch commit
Cc:

Description

In the new forums theme, breadcrumbs come and go depending on the view.

They should be consistently displayed in all views.

Attachments (2)

meta-1974.patch (3.5 KB) - added by SergeyBiryukov 3 years ago.
meta-1974.2.patch (4.5 KB) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (5)

#1 follow-up: @netweb
3 years ago

Previously removed in #1133 [2428], see ticket:1133#comment:8

We should probably remove wporg_support_breadcrumb() from themes/pub/wporg-forums/functions.php#L52, this function was originally added to parse the existing wp4.css styles into bbPress 2.x breadcrumbs

#2 in reply to: ↑ 1 @SergeyBiryukov
3 years ago

Replying to netweb:

We should probably remove wporg_support_breadcrumb()

I think we could restore the add_filter() call instead, as it appears to resolve #1951 as well.

See meta-1974.2.patch.

Last edited 3 years ago by SergeyBiryukov (previous) (diff)

#3 @coffee2code
3 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 4063:

Forums Theme: Consistently display breadcrumbs throughout forums.

Props SergeyBiryukov.
Fixes #1974.

Note: See TracTickets for help on using tickets.