Restore trash action for topics and replies for users with role capability

[netweb]

Introduced in [3898] , as part of the ​Tools Required this functionality should be restored.

By default, bbPress gives the "Trash" capability to "moderators and "keymasters"

​https://codex.bbpress.org/getting-started/before-installing/bbpress-user-roles-and-capabilities/

[netweb]

Per the support team handbook: ​https://make.wordpress.org/support/handbook/contributing-to-the-wordpress-forums/forum-moderator/bbpress-basics/#forum-roles:

"Moderators are tasked with keeping the forums tidy, they have the ability to archive and spam posts, as well as manage the spam and pending queues. They are expected to escalate any issues to the Keymasters if it is required."

"Keymasters generally perform the same tasks as a Moderator. In addition to moderator powers, they can block users from posting, elevate new users, and delete posts."

As such, restoring the "Trash" action should only be restored for bbPress 2.x "keymasters".

[samuelsidler]

Replying to netweb:

As such, restoring the "Trash" action should only be restored for "keymasters".

Not necessarily. The "keymaster" role in bbPress 1 is different than the same-named role in bbPress 2.

[netweb]

Replying to samuelsidler:

Replying to netweb:

As such, restoring the "Trash" action should only be restored for "keymasters".

Not necessarily. The "keymaster" role in bbPress 1 is different than the same-named role in bbPress 2.

Edited my previous post to state bbPress 2.x "keymasters"

[SergeyBiryukov]

It's currently possible to delete any topic from the admin if needed (and there's a handy Edit link in the admin bar for each topic).

Given the current comment in Hooks::admin_links()​, added in [3898]:

Remove 'Trash' from admin links. Trashing a topic or reply will eventually permanently delete it when the trash is emptied. Better to mark it as pending or spam.

Do we still need 'Trash' on the front end? If we do, I think it should be in the 'Topic Admin' sidebar section as a less commonly used action rather than an inline quick link. Let's discuss at the next Support Team meeting :)

[macmanx]

"Do we still need 'Trash' on the front end?" After a few months with the tools we have, much prefer to Archive things now, as that preserves a history of the content whereas trashing it will not as soon as it's emptied.

So, let's close this as a wontfix. ;)