Making WordPress.org

Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#2054 closed defect (bug) (fixed)

Forums: Missing i18n in wporg-forums theme

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: netweb's profile netweb
Milestone: Priority: normal
Component: buddypress.org Keywords: has-patch commit
Cc:

Description

The patch fixes a few issues:

  • Add missing i18n for the In: string
  • Add translator comments for placeholders in the same block
  • Align if/endif consistently

Attachments (3)

meta-2054.patch (2.4 KB) - added by SergeyBiryukov 9 years ago.
meta-2054.2.patch (2.4 KB) - added by netweb 9 years ago.
meta-2054.3.patch (4.5 KB) - added by SergeyBiryukov 9 years ago.

Download all attachments as: .zip

Change History (8)

@netweb
9 years ago

#1 @netweb
9 years ago

  • Component changed from Support Forums to buddypress.org

In meta-2054.2.patch use consistent text domain bbporg

Actually, I think this should be bborg, refresh incoming...

#1284 BuddyPress.org - String localization
#1285 bbPress.org - String localization

Shared "bb-base" common components should be: bborg
bbPress plugins, theme, and codex theme should be: bbporg
BuddyPress plugins, theme, and codex theme should be: bporg

FYI: None of these 3 projects have projects setup in GlotPress https://translate.wordpress.org/projects/meta

I'm not sure, cannot remember the current plan, plans, or if to continue support of localised BuddyPress sites such as https://es.buddypress.org and https://fr.buddypress.org

Last edited 8 years ago by SergeyBiryukov (previous) (diff)

#2 @SergeyBiryukov
9 years ago

Turned out bb_base_single_topic_description() and bb_base_single_forum_description() are already ported to the wporg-forums theme, so meta-2054.3.patch patches them there, and I guess meta-2054.2.patch can be moved to #1284 or #1285

#3 @SergeyBiryukov
9 years ago

  • Summary changed from Forums: Missing i18n in bb-base theme to Forums: Missing i18n in wporg-forums theme

#4 @netweb
8 years ago

  • Owner set to netweb
  • Resolution set to fixed
  • Status changed from new to closed

In 4127:

Forums Theme: Add missing i18n for the In: string.

This changeset also adds translator comments for placeholders in the same block and aligns if/endif consistently

Props SergeyBiryukov.
Fixes #2054.

Note: See TracTickets for help on using tickets.