WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#2089 closed defect (fixed)

DevHub: No search form on 404 page

Reported by: SergeyBiryukov Owned by: coffee2code
Milestone: Priority: normal
Component: Developer Hub Keywords: has-patch
Cc:

Description

  1. Go to https://developer.wordpress.org/non-existing/ (for example).
  2. The page says: "It looks like nothing was found at this location. Maybe try a search?".
  3. Ironically, there's no search form or breadcrumbs, like on other pages. There are two search forms in the HTML source code, but both are hidden with hide-if-js class.

Same for plugin and theme handbooks.

Attachments (2)

meta-2089.PNG (47.8 KB) - added by SergeyBiryukov 3 years ago.
2089.patch (3.0 KB) - added by keesiemeijer 3 years ago.
Add searchform to 404 pages

Download all attachments as: .zip

Change History (6)

@keesiemeijer
3 years ago

Add searchform to 404 pages

#2 @keesiemeijer
3 years ago

  • Keywords has-patch added

#3 @coffee2code
3 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 4242:

developer.wordpress.org: Add search form to 404 pages.

Props keesiemeijer.
Fixes #2089.

#4 @coffee2code
3 years ago

@keesiemeijer: Thanks, as always, for the patch!

I committed the patch with a slight change: I still assigned the 'searchform-handbook' for the search form when appearing in a handbook and left that as the original exception for enabling autocomplete. This allowed the autocomplete to work in the 404 search form outside the handbook. This necessitated a CSS tweak to ensure the autocomplete's list didn't get clipped due to the rather short 404 page content space.

Note: See TracTickets for help on using tickets.