Attachments (1)

meta-2090.patch (1.1 KB) - added by SergeyBiryukov 8 years ago.

Download all attachments as: .zip

Change History (4)

#1 @SergeyBiryukov
8 years ago

Can we join 2x"Archived" to one?

Not really, they have different context for a purpose. The first one is a (singular) post status, the second one is a (plural) title for a bbPress view with a list of posts. In Russian, we have a different translation for each case:

and is it possible to take the 'span' out of translatable strings, so nobody would/could accidentally translate class-names?

  • Archived <span class="count">(%s)</span>

No, since some locales translate the brackets too, see #WP31251#comment:17 and #WP31859.

  • <span itemprop="reviewCount">%d</span> review

There's a patch for that on #2035, see comment:4:ticket:2035.

  • %s out of <span itemprop="bestRating">5</span> stars

We could probably change it to %1$s out of %2$s stars (with a translator comment).

Last edited 8 years ago by SergeyBiryukov (previous) (diff)

#2 @SergeyBiryukov
8 years ago

  • Keywords has-patch commit added

meta-2090.patch addresses the last point.

#3 @coffee2code
8 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 4231:

Support Forums: I18n improvement in Ratings_Compat to move HTML out from translatable string.

Props SergeyBiryukov.
Fixes #2090.

Note: See TracTickets for help on using tickets.