Making WordPress.org

Opened 8 years ago

Closed 7 years ago

Last modified 6 years ago

#2097 closed defect (bug) (fixed)

Create a whitelist for oEmbed displays on the forums

Reported by: clorith's profile Clorith Owned by:
Milestone: Priority: normal
Component: Support Forums Keywords: needs-patch
Cc:

Description

With the bbPress 2 upgrade, we now have core oEmbed support with every post and topic, but oEmbed these are unreliable and doesn't truly belong there.

Currently most sites linked to are http only, this means we get mixed content warnings and broken embeds to begin with.

There's also no legitimate reason to embed a site on the forums, we're interested in clean links if anything, and embeds break this expectation.

Change History (10)

#1 @Otto42
8 years ago

I'd rather whitelist some set of sites that are okay and potentially useful, such as imgur and such. Objections?

#2 @ocean90
8 years ago

Maybe auto discovery should get disabled for the forums.

#3 @Clorith
8 years ago

I'm all for a whitelist for useful resources, imgur and the likes is very handy, like when people do screencasts they use youtube, so that one is also quite handy.

#4 @netweb
8 years ago

  • Keywords needs-patch added

#5 @ocean90
8 years ago

In 4181:

Support Forums: Disable <link> tag discovery for oEmbed.

See #2097.

#6 @SergeyBiryukov
8 years ago

  • Summary changed from Disable oEmbed displays on the forums to Create a whitelist for oEmbed displays on the forums

Related: #2469

This ticket was mentioned in Slack in #meta by sergey. View the logs.


7 years ago

This ticket was mentioned in Slack in #forums by clorith. View the logs.


7 years ago

#9 @Clorith
7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Marking as fixed, as we're no longer appear to do discoveries on URLs posted to the forums.

This ticket was mentioned in Slack in #meta by sergey. View the logs.


6 years ago

Note: See TracTickets for help on using tickets.