Opened 10 years ago
Closed 9 years ago
#2100 closed defect (bug) (fixed)
Google+ profile links are broken in Tagregator
| Reported by: | iandunn | Owned by: | coreymckrill |
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | WordCamp Site & Plugins | Keywords: | good-first-bug has-patch commit |
| Cc: |
Description
They link to https://plus.google.com/{username}, which doesn't exist. They should link to https://plus.google.com/{user_id} instead.
Example: https://2016.seattle.wordcamp.org/social-media-stream/
Attachments (2)
Change History (11)
#2
@
9 years ago
I made the changes ( 2100.diff ) into the .jsx + the .php file. Unfortunately I don't know how to compile react. But I tested it by manually replacing the var name in the front-end.js and it worked.. So when compiled it should be working as well.
Best regards,
Konstantinos
#4
@
9 years ago
There was an issue with my editor so I've updated the diff ( 2100.2.diff ) to meet the coding standards. Sorry for the inconvenience.
Best regards,
Konstantinos
#7
@
9 years ago
Works on my test site 👍🏻 Just need to run npm install and npm run build to create the built javascript file front-end.js. It looks like this also generates some soucemap (*.map) files, those can be ignored. Maybe the webpack config should be updated to not create those when running build.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
I'll take this on if no one else wants it. Should be an easy enough fix I'm guessing. I'll look into it.