Google+ profile links are broken in Tagregator

[iandunn]

They link to https://plus.google.com/{username}, which doesn't exist. They should link to https://plus.google.com/{user_id} instead.

Example: ​https://2016.seattle.wordcamp.org/social-media-stream/

[danieltj]

I'll take this on if no one else wants it. Should be an easy enough fix I'm guessing. I'll look into it.

[xkon]

Alrighty, I'm sure that I've found the way

I've originally tested by changing 'username' => $postmeta['author_name'][0], to get author_id instead and that worked fine.

So I've created an extra var 'userId' => $postmeta['author_id'][0], and changed the index.jsx accordingly with href={ url + author.userId } .

My problem is that I have no idea how to recompile it into front-end.js so I can't see the changes to be sure they work... ( I know they should be working but just to be sure ).

Shouldn't the recompile happen automatically or something?

By the way, I've never worked with React so this was a good-first-bug for me to try and tackle I guess :D .

Best regards,
Konstantinos

[xkon]

Fixed the author link

[xkon]

Coding Standards

[xkon]

There was an issue with my editor so I've updated the diff ( 2100.2.diff ) to meet the coding standards. Sorry for the inconvenience.

Best regards,
Konstantinos

[ryelle]

Works on my test site 👍🏻 Just need to run npm install and npm run build to create the built javascript file front-end.js. It looks like this also generates some soucemap (*.map) files, those can be ignored. Maybe the webpack config should be updated to not create those when running build.

[coreymckrill]

Thanks for the test, @ryelle !

[coreymckrill]

Fixed with ​https://plugins.trac.wordpress.org/changeset/1707260/