WordPress.org

Making WordPress.org

Opened 22 months ago

Closed 5 weeks ago

#2102 closed defect (fixed)

Missing i18n in bb-base theme

Reported by: SergeyBiryukov Owned by: obenland
Milestone: Priority: normal
Component: bbpress.org Keywords: has-patch needs-refresh
Cc:

Description

Same as #2054, but for bb-base theme:

  • Add missing i18n for the In: string
  • Add translator comments for placeholders in the same block
  • Use a consistent text domain (bbporg vs. bbpress)
  • Align if/endif consistently

Attachments (2)

meta-2102.patch (5.5 KB) - added by SergeyBiryukov 22 months ago.
meta-2102.2.patch (7.6 KB) - added by netweb 22 months ago.

Download all attachments as: .zip

Change History (10)

#1 follow-up: @netweb
22 months ago

  • Keywords commit removed

Updated meta-2102.2.patch to use the bborg text domain as noted 2054#comment:1

Replying to netweb:

#1284 BuddyPress.org - String localization
#1285 bbPress.org - String localization

Shared "bb-base" common components should be: bborg
bbPress plugins, theme, and codex theme should be: bbporg
BuddyPress plugins, theme, and codex theme should be: bporg

Will refresh #1284 and #1285 and commit all 3 tickets together soon.

Last edited 12 months ago by SergeyBiryukov (previous) (diff)

#2 @coffee2code
21 months ago

  • Owner set to netweb
  • Status changed from new to assigned

Assigning to you @netweb (along with #1284 and #1285) since it seems you have them in hand.

#3 in reply to: ↑ 1 ; follow-up: @SergeyBiryukov
12 months ago

Replying to netweb:

Will refresh #1284 and #1285 and commit all 3 tickets together soon.

meta-2102.2.patch is not a complete patch for missing i18n in bb-base theme, it only handles functions.php.

I could update it to handle other files, but let's commit #1284, #1285, and #3009 first :) Just refreshed the patches there.

#4 @dd32
6 months ago

In 6367:

BuddyPress.org & bbPress.org: Internationalise some strings.

Props SergeyBiryukov.
See #2102.

#5 in reply to: ↑ 3 @netweb
6 months ago

  • Keywords needs-refresh added

Replying to SergeyBiryukov:

meta-2102.2.patch is not a complete patch for missing i18n in bb-base theme, it only handles functions.php.

I could update it to handle other files, but let's commit #1284, #1285, and #3009 first :) Just refreshed the patches there.

Following up from [6367] a refresh of the patch for this per the above is needed

#6 @obenland
5 weeks ago

  • Owner changed from netweb to obenland
  • Status changed from assigned to accepted

#7 @obenland
5 weeks ago

In 7305:

BB Base: i18n improvements.

Updates remaining strings to be translatable.

See #2102.

#8 @obenland
5 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed
Note: See TracTickets for help on using tickets.