Forums: Wrong page number in some reply links

[SergeyBiryukov]

1. Open this reply:
   ​https://wordpress.org/support/topic/after-update-to-46-keep-getting-curl-error-23/page/2/#post-7680728 (That particular topic is already fixed.)
2. The next reply on the same page suddenly has /page/3/ instead of /page/2/:
   ​https://wordpress.org/support/topic/after-update-to-46-keep-getting-curl-error-23/page/3/#post-8157376

Steps to reproduce:

1. Create a topic and two pages of replies.
2. Archive or mark as spam some replies on the first page.
3. The first page now displays some replies from the second page, but their URLs still link to the second page.

[SergeyBiryukov]

In 5693:

Support Forums: Update the necessary meta data when editing a reply created before 2017-07-17, as those replies can have potentially inaccurate data.

See #2110, #2481.

[SergeyBiryukov]

In 5695:

Support Forums: In Dropin::update_old_reply_meta(), don't recalculate position for archived replies.

Archived replies are not returned by bbp_get_all_child_ids(), so they end up with a zero position.

See #2110, #2481.

[obenland]

@SergeyBiryukov What's the status on this?

[tellyworth]

Closing as fixed, please re-open if that's not correct.

[SergeyBiryukov]

Related: #6443