Internationalize WordCamp Dashboard Widgets plugin

[iandunn]

The WordCamp Dashboard Widgets plugin needs to be internationalized.

The escaping translation functions (esc_html__(), esc_attr_e(), etc) should be used instead of their non-escaping counterparts.

[chandrapatel]

Hi @iandunn

I will work on it.

[chandrapatel]

Hi @iandunn

I've submitted patch 2143.patch

Please check and let me know if it's fine.

[coreymckrill]

@chandrapatel Thanks for the patch! There are a few instances where the translation strings are not being escaped, probably because they contain HTML. In these cases, the strings should still be sanitized with wp_kses(). Something like this:

<?php 
printf( 
  wp_kses(
    __( 'Please send us <a href="%s">the "about" text and banner image</a> for your central.wordcamp.org page.', 'wordcamporg' ),
    array( 'a' => array( 'href' => true ) )
  ),
  'https://make.wordpress.org/community/handbook/wordcamp-organizer/first-steps/web-presence/your-page-on-central-wordcamp-org/'
); 
?> 

[chandrapatel]

Hi @coreymckrill

I've made changes as you suggested. See 2143.1.patch

Please check and let me know if its fine.

[coreymckrill]

In 4655:

WordCamp Dashboard Widgets: i18n for text strings

Fixes #2143
Props chandrapatel, coreymckrill

[coreymckrill]

@chandrapatel Thanks, and nice work!

A couple of suggestions for your next patch:

• For PHP files, your indents should be with ​tab characters rather than spaces.
• Keep the patch focused on the ticket issue. This patch had a couple of miscellaneous changes to comment punctuation and additional commas on array items. These aren't bad, but they distract from the important changes in the patch, so it's best to include them separately.

[chandrapatel]

Hi @coreymckrill

Sure, I will. Thanks for your suggestions.