Making WordPress.org

Opened 11 years ago

Closed 11 years ago

#220 closed enhancement (fixed)

Remove "Replace existing attachment of the same name" option when adding Trac ticket attachments

Reported by: raamdev's profile raamdev Owned by: nacin's profile nacin
Milestone: Priority: normal
Component: Trac Keywords:
Cc:

Description

During Boston WordCamp Contributor Day, Nacin mentioned that the option to "Replace existing attachment of the same name" when adding attachments to Trac tickets should be removed or hidden, as that option should never be used (we always want to keep the previously attached files).

Attachments (1)

Screen Shot 2013-10-31 at 10.23.38 AM.png (114.4 KB) - added by raamdev 11 years ago.
Screenshot showing "Replace existing attachment of the same name" option

Download all attachments as: .zip

Change History (4)

@raamdev
11 years ago

Screenshot showing "Replace existing attachment of the same name" option

#1 @kpdesign
11 years ago

I believe it should be hidden completely from regular Trac users, but show for anyone who has Trac gardening privs, and unchecked by default for them.

#2 @SergeyBiryukov
11 years ago

I think it's okay to use it for some quick and small changes right after a patch has been uploaded (like fixing a typo), as long as the previous patch hasn't been reviewed by anyone yet.

I'm fine with hiding it for regular users, but I'd prefer to keep it for Trac gardeners.

#3 @nacin
11 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 178:

Trac: Remove 'Replace existing attachment of the same name' for non-bug gardeners.

fixes #220.

Note: See TracTickets for help on using tickets.