Making WordPress.org

Opened 10 years ago

Last modified 7 days ago

#2207 new enhancement

GTEs should be able to mark PTE requests as resolved

Reported by: SergeyBiryukov Owned by:
Priority: normal Milestone:
Component: Make (Get Involved) / P2 Keywords:
Cc:

Description

At the moment, GTEs can resolve PTE requests, but cannot mark them as resolved.

The checkboxes in ​PTE requests are only clickable for editors on make/polyglots blog, which means someone needs to track comments for all requests and click the corresponding checkbox once a GTE replies with "Done", etc.

To make the whole process more user-friendly, GTEs should be able to mark PTE requests for their locale as resolved themselves.

Brief Slack discussion: ​https://wordpress.slack.com/archives/polyglots/p1478195767000374

Change History (9)

#1 @SergeyBiryukov
10 years ago

  • Type defect → enhancement

This ticket was mentioned in ​Slack in #meta-i18n by sergey. ​View the logs.


10 years ago

This ticket was mentioned in ​Slack in #meta-i18n by sergey. ​View the logs.


9 years ago

This ticket was mentioned in ​Slack in #polyglots by sergey. ​View the logs.


9 years ago

This ticket was mentioned in ​Slack in #polyglots by sergey. ​View the logs.


8 years ago

​@tobifjellner commented on ​PR #1159:


8 days ago
#8

Some small things to double-check
I didn't read the code and am just adding more context:

  • when the PTE role is given, this includes all variants of that locale. I remove tags for specific variants, leaving only the main locale tag.
  • Some times one and the same locale tag is mentioned more than once in a post. Say, in the main text, the poster uses a tag, but then the tag is repeated as a checked item. You shouldn't count the number of locale tags, but how many locales have been tagged.

​@ekamran commented on ​PR #1159:


7 days ago
#9

Thanks @tobifjellner, both were worth checking.

Variants: you're right, this was a gap. A request tagged de_DE and de_DE_formal counted as two locales, so the German GTEs couldn't have marked it done until the variant tag was removed. 6d16bfcce now counts a variant as its parent locale. A variant of another locale still counts on its own, so de_DE with de_CH_informal stays a request for two locales.

Repeated tags: the check counts the post's tags, not mentions in the text, and a post has each tag only once. So a locale named in the text and again as a checked item is still one locale. Of the last 100 requests, 32 name one of their locales two or more times in the text, and each has that tag once.

Note: See TracTickets for help on using tickets.