WordPress.org

Making WordPress.org

Opened 13 months ago

Closed 3 months ago

Last modified 3 months ago

#2218 closed enhancement (fixed)

Meetings: Event repetition options need to be more dynamic

Reported by: hlashbrooke Owned by: SergeyBiryukov
Milestone: Priority: normal
Component: Make (Get Involved) / P2 Keywords: has-patch has-screenshots
Cc:

Description

On Make/Meetings, the current options for event repetition allow you to set events to repeat monthly or weekly on a specified date (such as the 2nd of every month), but you can't specify something to repeat on a date like the first Thursday of every month.

The monthly Community Team chat has a schedule exactly like that - it occurs on the first Thursday of every month, which means that it is consistently incorrect on Make/Meetings. For reference, here is the post for that meeting: https://make.wordpress.org/wp-admin/post.php?post=1710&action=edit

I don't know if there are other meetings that follow a similar schedule, but it would be great to have that sort of repetition as an option.

Attachments (7)

2218.patch (14.7 KB) - added by SergeyBiryukov 3 months ago.
2218.PNG (12.9 KB) - added by SergeyBiryukov 3 months ago.
2218.2.patch (14.4 KB) - added by SergeyBiryukov 3 months ago.
2218.2.PNG (12.9 KB) - added by SergeyBiryukov 3 months ago.
2218.3.patch (14.6 KB) - added by SergeyBiryukov 3 months ago.
2218.3.PNG (13.0 KB) - added by SergeyBiryukov 3 months ago.
2218.4.patch (14.7 KB) - added by SergeyBiryukov 3 months ago.

Download all attachments as: .zip

Change History (27)

#1 @samuelsidler
10 months ago

  • Summary changed from Event repetition options on Make/Meetings need to be more dynamic to Meetings: Event repetition options need to be more dynamic

This ticket was mentioned in Slack in #community-events by hlashbrooke. View the logs.


5 months ago

This ticket was mentioned in Slack in #meta by hlashbrooke. View the logs.


3 months ago

This ticket was mentioned in Slack in #meta-wordcamp by sergey. View the logs.


3 months ago

#6 @SergeyBiryukov
3 months ago

  • Keywords has-patch has-screenshots added; needs-patch removed

In 2218.patch:

  • Add a "Week of month" "Occurrence in a month" option: 2218.PNG, allowing for a more flexible schedule like the first and third Thursday of every month for the Community Team. Day of week is taken from the Start Date.
  • Include "Biweekly" option from #3075.
  • Remove obsolete JS code for Tab navigation. It causes an error, as the post type does not support text editor.
  • Remove unused variables in ::save_meta_boxes().
  • Some coding style and readability fixes.

Props should include @SergeyBiryukov and @ketuchetan for his initial patch on #3075.

cc @coreymckrill

Last edited 3 months ago by SergeyBiryukov (previous) (diff)

@SergeyBiryukov
3 months ago

#7 @SergeyBiryukov
3 months ago

#3075 was marked as a duplicate.

#8 @SergeyBiryukov
3 months ago

Add a "Week of month" option, allowing for a more flexible schedule like the first and third Thursday of every month

Just noticed that "Week of month" is not an accurate label for that. Maybe "Occurence in a month"?

#9 @SergeyBiryukov
3 months ago

2218.2.patch changes the label to "Occurence in a month": 2218.2.PNG. The logic is accurate as is.

#10 follow-up: @hlashbrooke
3 months ago

This is great @SergeyBiryukov! I assume the occurence day will be based on the day of the week that the start date falls on? So if the start date is a Thursday, then the meeting will repeat on the 1st and 3rd Thursdays of each month. If that's the case, then this is spot on for what the goal of this ticket was.

#11 in reply to: ↑ 10 ; follow-up: @SergeyBiryukov
3 months ago

Replying to hlashbrooke:

I assume the occurence day will be based on the day of the week that the start date falls on?

Yes, that's correct.

#12 @SergeyBiryukov
3 months ago

2218.3.patch fixes a typo: OccurenceOccurrence.

#13 follow-ups: @ocean90
3 months ago

Does this include a fix for #1657?

#14 in reply to: ↑ 13 @SergeyBiryukov
3 months ago

Replying to ocean90:

Does this include a fix for #1657?

No, that sounds like a separate issue. I'll look into it and either add a patch there or include it here.

#15 in reply to: ↑ 11 @hlashbrooke
3 months ago

Replying to SergeyBiryukov:

Replying to hlashbrooke:

I assume the occurence day will be based on the day of the week that the start date falls on?

Yes, that's correct.

That's perfect then - thanks for working on this!

#16 in reply to: ↑ 13 @SergeyBiryukov
3 months ago

Replying to ocean90:

Does this include a fix for #1657?

2218.4.patch does :) Next date should only be calculated if the start date has already passed, which isn't the case for meetings starting later this week. If the start date is not passed yet, it should be used as is.

#17 @SergeyBiryukov
3 months ago

New summary for 2218.4.patch:

  • Add an "Occurrence in a month" option: 2218.3.PNG, allowing for a more flexible schedule like the first and third Thursday of every month for the Community Team. Day of week is taken from the Start Date.
  • Include "Biweekly" option from #3075.
  • Include a fix for #1657: meetings with a Start Date later on the current week are no longer skipped.
  • Remove obsolete JS code for Tab navigation. It causes an error, as the post type does not support text editor.
  • Remove unused variables in ::save_meta_boxes().
  • Some coding style and readability fixes.

Props should include @SergeyBiryukov and @ketuchetan for his initial patch on #3075.

#18 @SergeyBiryukov
3 months ago

In 5849:

Make/Meetings: Add "Biweekly" option for recurrent meetings.

Props ketuchetan for initial patch.
Fixes #3075. See #2218.

#19 @SergeyBiryukov
3 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 5850:

Make/Meetings: Add "Occurrence in a month" option for recurrent meetings, allowing for a more flexible schedule like the first and third Thursday of every month.

The occurrence day is based on the day of week that the Start Date falls on.

Fixes #2218.

#20 @SergeyBiryukov
3 months ago

In 5851:

Make/Meetings: Correct the logic for "Occurrence in a month" option.

Next occurrence should be calculated in the current month, not in the Start Date month.

See #2218.

Note: See TracTickets for help on using tickets.