WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 2 years ago

#2229 closed defect (fixed)

Missing translation functions for budget-tool under "wordcamp-payments" plugin for WordCamp.org

Reported by: Thomas Vitale Owned by: iandunn
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: has-patch
Cc:

Description

In the file "views/budget-tool/main.php" all strings are not ready for translation.

Attachments (2)

2229.diff (12.1 KB) - added by Thomas Vitale 3 years ago.
Added () and _e() functions to make all the strings ready for translation
2229.1.diff (12.4 KB) - added by Thomas Vitale 3 years ago.
Replace the _e() function with the esc_html_e() function on order to escape strings.

Download all attachments as: .zip

Change History (13)

@Thomas Vitale
3 years ago

Added () and _e() functions to make all the strings ready for translation

#1 @Thomas Vitale
3 years ago

  • Keywords has-patch added; needs-patch removed

@Thomas Vitale
3 years ago

Replace the _e() function with the esc_html_e() function on order to escape strings.

#2 @iandunn
3 years ago

  • Owner set to iandunn
  • Status changed from new to accepted

Thanks Thomas! I'm gonna go ahead and close the other tickets as duplicates of this, since it'll be easier to just do them all at once, rather than dealing with the overhead of a separate ticket for each file.

When this ticket is reviewed/merged, the patches attached to the following tickets should be reviewed along with it:

#3 @iandunn
3 years ago

#2230 was marked as a duplicate.

#4 @iandunn
3 years ago

#2233 was marked as a duplicate.

#5 @iandunn
3 years ago

#2234 was marked as a duplicate.

#6 @iandunn
3 years ago

#2235 was marked as a duplicate.

#7 @iandunn
3 years ago

#2237 was marked as a duplicate.

#8 @Thomas Vitale
3 years ago

Thanks @iandunn, I'm sorry for the multiple tickets, I thought that I was not allowed to load a patch for more than one file. It's much easier to handle just a ticket, indeed!

Do you want me to prepare a unique patch and load it here?

#9 @iandunn
3 years ago

No worries :)

I can just apply all of the above patches individually, it shouldn't cause any conflicts.

#10 @Thomas Vitale
3 years ago

Ok, thanks :)

#11 @iandunn
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

Merged in r4967

Note: See TracTickets for help on using tickets.