WordPress.org

Making WordPress.org

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#2244 closed defect (fixed)

Redirect back to the ticket you were on when you sign in

Reported by: melchoyce Owned by: nacin
Milestone: Priority: normal
Component: Trac Keywords:
Cc:

Description

I get signed out of trac every couple of hours, and then it's really irritating to have to sign back in, only to be dropped onto core.trac.wordpress.org instead of the ticket I was previously viewing. I have to go back to the ticket and reload so it knows I'm signed in. Can this get fixed so you're redirected back to where you can from?

Change History (6)

#1 @ocean90
3 years ago

  • Type changed from enhancement to defect

I reported this already in October, see https://make.wordpress.org/systems/2016/09/29/hello-can-someone-please-change/#comment-1141. But systems have no time for us so I guess we've to live with that for a while.

#2 @nacin
3 years ago

I don't think this was from the Apache configuration. I've done the change requested by @ocean90, but it wasn't enough to fix this.

login.wordpress.org uses wp_login_form() which is meant to be embedded in a page so you'd expect it to redirect back to itself. That's why its internal default is REQUEST_URI rather than the referer or a redirect_to.

In wporg-sso/wp-plugin.php, we change the default redirect to the value of redirect_to. But we never actually bother to fall back to the referer. So I'm now fixing that.

#3 @nacin
3 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 4413:

SSO: Consider the referer when doing a login redirect.

fixes #2244.

#4 follow-up: @nacin
3 years ago

@melchoyce "I get signed out of trac every couple of hours" - this seems very wrong. Can you reproduce this with any regularity? Your WordPress.org login should last for a while.

#5 in reply to: ↑ 4 @melchoyce
3 years ago

Replying to nacin:

@melchoyce "I get signed out of trac every couple of hours" - this seems very wrong. Can you reproduce this with any regularity? Your WordPress.org login should last for a while.

Yeah, it's been a constant fact of life for at least a couple months now.

#6 @nacin
3 years ago

In 4417:

SSO: Send no-cache headers. see #2244.

Note: See TracTickets for help on using tickets.