WordPress.org
Get WordPress

Making WordPress.org

Opened 8 years ago

Closed 8 years ago

Last modified 6 years ago

#2303 closed defect (bug) (fixed)

New plugin directory plugin pages don't have social metadata

Reported by: joostdevalk's profile joostdevalk Owned by: obenland's profile obenland
Milestone: Plugin Directory v3.0 Priority: normal
Component: Plugin Directory Keywords: has-patch
Cc:

Description

They're lacking og: and twitter: data.

Attachments (5)

social_meta_data.diff​ (1.8 KB) - added by joostdevalk 8 years ago.
First stab at patch
social_meta_data.2.diff​ (1.8 KB) - added by joostdevalk 8 years ago.
Typo fixed.
social_meta_data.3.diff​ (1.8 KB) - added by joostdevalk 8 years ago.
Fixed is_singular
social_meta_data.4.diff​ (2.1 KB) - added by joostdevalk 8 years ago.
Catch it when banners do not exist
social_meta_data.5.diff​ (2.2 KB) - added by joostdevalk 8 years ago.
Patch that does actually fix the new metadata

Download all attachments as: .zip

Change History (11)

@joostdevalk
8 years ago

First stab at patch

@joostdevalk
8 years ago

Typo fixed.

@joostdevalk
8 years ago

Fixed is_singular

@joostdevalk
8 years ago

Catch it when banners do not exist

#1 @obenland
8 years ago

  • Owner set to obenland
  • Resolution set to fixed
  • Status changed from new to closed

In 4481:

Plugin Directory: Enable richer social media integrations.

Props joostdevalk.
Fixes #2303.

#2 @joostdevalk
8 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening because it doesn't work correctly yet. Will attach new patch.

@joostdevalk
8 years ago

Patch that does actually fix the new metadata

#3 @joostdevalk
8 years ago

New patch changes putting in post_id to putting in a full plugin object. Also codes the output slightly more defensively by wrapping everything in esc_url or esc_attr.

This ticket was mentioned in ​Slack in #meta by tellyworth. ​View the logs.
8 years ago

#5 @obenland
8 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 4505:

Plugin Directory: Use get_post() for template functions.

Template functions should fall back to the global post object.
Also fixes a bug where assets weren't loaded correctly while in the loop.

Props joostdevalk for initial patch.
Fixes #2303.

#6 @ocean90
6 years ago

In 7208:

Plugin Directory: In social_meta_data() don't override the 2x banner if it exists as 2x.

See #2303.

Note: See TracTickets for help on using tickets.