Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#2377 closed defect (bug) (fixed)

Add gettext to help tab titles in Remote CSS plugin.

Reported by: mayukojpn's profile mayukojpn Owned by: iandunn's profile iandunn
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: has-patch commit


Hi! I found help tab titles aren't translatable in Remote CSS plugin.

Attachments (3)

2377.patch (676 bytes) - added by mayukojpn 7 years ago.
貼り付けた画像_2017_01_12_19_45.png (179.4 KB) - added by mayukojpn 7 years ago.
2377-2.patch (751 bytes) - added by mayukojpn 7 years ago.
Thanks @iandunn ! I changed the style a bit.

Download all attachments as: .zip

Change History (8)

7 years ago

#1 @iandunn
7 years ago

  • Keywords commit added
  • Owner set to iandunn
  • Status changed from new to accepted

Thanks! The patch looks good to me. I've added it to the merge list.

It'd probably improve readability a bit if each string were a new line, but I can easily do that when I commit it.

7 years ago

Thanks @iandunn ! I changed the style a bit.

#2 @Kenshino
7 years ago

Wouldn't it make sense to also use sprintf and only write the translation function once? The array should be as simple as possible

#3 @mayukojpn
7 years ago

@Kenshino We should use gettext one by one so that GlotPress can extract translatable strings. Some plugin authors did same way as you so we couldn't generate .pot file 😞 :

#4 @iandunn
7 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 4966:

Remote CSS: Internationalize contextual help tab names

Fixes #2377
Props mayukojpn

#5 @coreymckrill
7 years ago

In 5118:

WC Remote CSS: Don't use a translated string as an ID

In #4966, making the tab labels translatable introduced the possibility
of a fatal error, because the label became part of the required filename.
This removes the possibility by using a separate ID string for the filename.

See #2377

Note: See TracTickets for help on using tickets.