Making WordPress.org

Opened 4 years ago

Closed 8 months ago

#2383 closed enhancement (fixed)

Add a meta field in the Sponsor CPT for Twitter handle

Reported by: andreamiddleton Owned by:
Milestone: Priority: normal
Component: WordCamp Site & Plugins Keywords: good-first-bug has-patch needs-testing

Description (last modified by coreymckrill)

It would be a nice convenience for organizers if we had a field for a sponsor's twitter handle, so it’s easier to tweet a thank you. This would be particularly helpful in the case of global sponsors, but I could see a use case for local sponsors as well. It would not need to be a required field.

Update: the Twitter Handle field has been added for the Sponsor CPT. A similar field still needs to be added to the multi-event-sponsor plugin, though. See #3.

Attachments (3)

2383.diff (2.4 KB) - added by chandrapatel 4 years ago.
2383.1.diff (2.9 KB) - added by chandrapatel 3 years ago.
2383.2.diff (892 bytes) - added by chandrapatel 3 years ago.

Download all attachments as: .zip

Change History (14)

#1 @iandunn
4 years ago

  • Keywords good-first-bug needs-patch added
  • Owner set to iandunn
  • Status changed from new to accepted

4 years ago

#2 @chandrapatel
4 years ago

  • Keywords has-patch added; needs-patch removed

HI @iandunn

I've added Twitter Handle: meta field in Sponsor CPT. I've attached a patch. 2383.diff

Please check and let me know if it's fine.


#3 @iandunn
4 years ago

That looks good, thanks!

Eventually we'll also want to add a corresponding field to the multi-event-sponsors plugin, and copy the value from those global sponsors to the wcpt sponsor posts when new sites get created. 2383.diff can be committed without that, though.

We've got a backlog of patches to review and commit, but I've added this one to the list. Hoping to find some time soonish.

#4 @coreymckrill
4 years ago

In 5509:

WordCamp: Add Twitter Handle field to Sponsor CPT

This commit adds the field to the Sponsor CPT on individual WC sites.
A corresponding field in the multi-event-sponsors plugin still needs
to be added.

Refs #2383
Props chandrapatel

#5 @coreymckrill
4 years ago

  • Description modified (diff)
  • Keywords needs-patch added; has-patch removed

3 years ago

#6 @chandrapatel
3 years ago

  • Keywords has-patch added; needs-patch removed

Hi @coreymckrill

I've added Twitter Handle: meta field in the multi-event-sponsors plugin. I've attached a patch. 2383.1.diff

Please check and let me know if it's fine.


3 years ago

#7 @chandrapatel
3 years ago

Hi @coreymckrill

I've also made changes in wcpt plugin to copy value of Twitter Handle: meta field from global sponsors to local sponsors on site clone as @iandunn suggested. But I'm not able to test this feature in my local environment.

I've attached patch. 2383.2.diff

#8 @iandunn
3 years ago

  • Owner iandunn deleted
  • Status changed from accepted to assigned

#9 @coreymckrill
3 years ago

  • Keywords needs-testing added

This ticket was mentioned in Slack in #meta-wordcamp by ryelle. View the logs.

9 months ago

#11 @ryelle
8 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged the patches in 098e8fa. Thanks @chandrapatel !

Note: See TracTickets for help on using tickets.