Plugin Directory: Restrict Devs concurrent submissions

[Ipstenu]

The queue is rarely longer than 7 days. As such, the burden of reviews can get a little weird when people submit upwards of 10 plugins at once. Wish it was a joke. The problem is most of the time the reviews are all the same results, with the same errors repeating in each separate plugin.

It would be nice if we could restrict submissions as follows:

If a developer has NO active plugins, they can submit one plugin

Otherwise, if a developer has 3+ plugins in 'draft' or 'pending' (which means in review), they cannot submit any more. Give them a nice message of "You have too many plugins in the queue. Please wait for them to be approved before submitting any more."

This would mitigate repetition of reviews, which can be pretty onerous.

[SergeyBiryukov]

The patch on #2594 introduces an Upload::get_submitted_plugins() method that could be used here.

[Ipstenu]

Actually ... can we make it one in review at a time?

Make them decide what the heck to do before submitting more.

This would help keep the pending-reply queue lower. it's almost 700 from people who want multiple plugins and never finish.

[SergeyBiryukov]

In 6023:

Plugin Directory: Limit plugin submissions to one at a time.

Remove the upload form if the developer already has a plugin in the review queue.

Fixes #2386.

[SergeyBiryukov]

In 6025:

Plugin Directory: Change "You have 1 plugin in the review queue" notice wording to "You already have a plugin in the review queue".

See #2386.

[Ipstenu]

We missed an edge case.

If you upload a plugin, the submit box remains on the success page. :facepalm: We should hide it there, as it would permit users to submit multiple plugins in a row.

[SergeyBiryukov]

In 6045:

Plugin Directory: Remove the upload form after a successful upload.

Make Upload_Handler::process_upload() return WP_Error on failure.

Fixes #2386.

[SergeyBiryukov]

In 6046:

Plugin Directory: Adjust the condition for displaying the upload form for better readability.

See #2386.

[SergeyBiryukov]

In 6119:

Plugin Directory: Stop processing the upload if the developer already has a plugin in the review queue.

Fixes #3251. See #2386.