WordPress.org

Making WordPress.org

Opened 6 years ago

Last modified 22 months ago

#24 assigned enhancement

WordCamp Sessions: Default sort order for Manage Sessions should be "Time"

Reported by: danielbachhuber Owned by:
Milestone: Priority: low
Component: WordCamp Site & Plugins Keywords: good-first-bug needs-refresh needs-patch
Cc:

Description

Because Sessions are closely tied to a schedule, the default sort order in the Manage Sessions view should be whatever post meta field is associated with "Time". ASC would work just fine.

Attachments (2)

24.diff (1.2 KB) - added by WPStagecoach 5 years ago.
24.2.diff (876 bytes) - added by WPStagecoach 5 years ago.
This is the patch to apply!

Download all attachments as: .zip

Change History (11)

#1 @iandunn
6 years ago

  • Cc ian.dunn@… added

#2 @iandunn
6 years ago

  • Owner set to iandunn
  • Status changed from new to assigned

#3 @iandunn
5 years ago

  • Keywords good-first-bug added

#4 @iandunn
5 years ago

  • Status changed from assigned to accepted

@WPStagecoach
5 years ago

#5 @WPStagecoach
5 years ago

I uploaded a patch that causes the Sessions to be listed by date in the admin panel.

@WPStagecoach
5 years ago

This is the patch to apply!

#6 @WPStagecoach
5 years ago

Sorry--after I submitted the first patch, I found that someone already had start to implement this, so I used their function, and modified the logic a bit so that the default (blank) 'orderby' is set to ascend the time field.

#7 @iandunn
5 years ago

This looks good, thanks Jonathan :)

A few small tweaks I'd suggest:

  1. Add the date to the Time column, because when there are sessions from multiple days it can be confusing to see the times appear to be out of order.
  2. Rename the column to Session Date / Time because it now includes the date, but we don't want it confused with the post's Date column. Another idea would be to just remove the Core Date column, since it's not that useful in this situation.
  3. There are a few coding standards issues around whitespace usage.

A good follow-up patch would be to remove the old "voodoo" workaround because wordpress:#23268 is fixed now.

#8 @coreymckrill
2 years ago

  • Keywords needs-refresh needs-patch added

#9 @iandunn
22 months ago

  • Owner iandunn deleted
  • Status changed from accepted to assigned
Note: See TracTickets for help on using tickets.