WordPress.org

Making WordPress.org

Opened 2 years ago

Closed 2 years ago

Last modified 3 months ago

#2437 closed defect (fixed)

Handbook sidebar background is off on large resolution screens

Reported by: dingo_d Owned by: samuelsidler
Milestone: Priority: normal
Component: Make (Get Involved) / P2 Keywords: ui-feedback has-patch
Cc:

Description

I noticed it yesterday on my 25" 2560x1440 screen that the sidebar on the handbook pages and the background (that is set as a sharp gradient of the entire .handbook-template-default #page div) gets misaligned (I'll attach an image of the issue below).

The fix is to add a background to the sidebar so that no mater how big the resolution gets, there won't be any 'escaping' of the background.

.handbook-template-default #secondary {
    margin: 0;
    background: #fafafa;
}

Attachments (2)

handbook_issue.jpg (468.0 KB) - added by dingo_bastard 2 years ago.
2437.patch (1.1 KB) - added by dingo_bastard 2 years ago.
The major fix is on the line 1037, other fixes are probably just due to trimming of trailing white space I have set up in Sublime

Download all attachments as: .zip

Change History (5)

@dingo_bastard
2 years ago

The major fix is on the line 1037, other fixes are probably just due to trimming of trailing white space I have set up in Sublime

#1 @dingo_bastard
2 years ago

  • Keywords has-patch added

#2 @samuelsidler
2 years ago

  • Owner set to samuelsidler
  • Resolution set to fixed
  • Status changed from new to closed

In 4823:

Breathe: Fix handbook sidebar background on large resolution screens.

Also, merge two rules into one. (We really need to clean up this stylesheet at some point.)

Props dingo_bastard.
Fixes #2437.

#3 @dd32
3 months ago

  • Reporter changed from dingo_bastard to dingo_d
Note: See TracTickets for help on using tickets.