Opened 8 years ago
Closed 7 years ago
#2448 closed defect (bug) (fixed)
Restore IRC channel archives on irclogs.wordpress.org
Reported by: | SergeyBiryukov | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Component: | Communication (Matrix, Slack, IRC) | Keywords: | has-patch |
Cc: |
Description
Reported by @netweb in #meta:
netweb: Does anyone know if an archive of the IRC logs was ever created before the removal of the channels at https://irclogs.wordpress.org/ ?
Only #wordpress-dev exists there these days :(
sergey: I think it might be due to thefilemtime()
check: https://code.trac.wordpress.org/browser/irc-logger/public_html/index.php?marks=28,29#L25
Maybe the other channels didn't have any activity for some time? If that's the case, that check should probably be removed.
clorith: All channels should be without activity except#wordpress
(we've removed the logger from all other rooms)
So yeah, you're probably right
Currently, the IRC logs viewer skips .sqlite.db
files older than a day. The check was already there in the initial IRC logger commit, probably to skip inactive channels. Now that the logger was removed from most of the channels excerpt #wordpress
, I guess this check should be removed to make all the archives available again.
Attachments (1)
Change History (8)
#2
@
8 years ago
Fixed in r433-code.
That site requires a deploy by systems. Here's the request for them to do so.
#3
@
8 years ago
- Keywords commit removed
Removing commit tag since the code has been committed. Just waiting on a deploy by systems.
#5
@
8 years ago
Committed a different fix in r434-code, as requested by barry:
IRC Logger: Revert [433] and instead only allow listing of old logs if new constant IRC_LOGGER_SHOW_OLD_LOGS is true. See https://make.wordpress.org/systems/2017/01/27/can-we-get-irclogs-wordpress-org-updated/ See #meta2448.
#6
@
8 years ago
The archives are actually viewable if you know the channel name:
https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2014-10-14&sort=asc
It's just that the list of channels is not displayed. [434] should still fix that, apparently just hasn't been deployed yet.
Thanks for creating the ticket and a patch, fingers crossed I'll be able to find what I was looking for once this is in :+1
@coffee2code any chance you can get to this anytime soon please?