Theme Diffs occasionally diff wrong versions

[nofearinc]

While conducting theme reviews today, some of the themes that updated versions with more than 1 step (like from 2.08 to 2.11) had their diffs wrong.

For instance, ​iRibbon 2.0.22 was uploaded after 2.0.20, but the diff link is:

​http://themes.trac.wordpress.org/changeset?old_path=/iribbon/2.0.20&new_path=/iribbon/2.0.21

Another strange thing is that 2.0.21 is the "new path" while 2.0.22 is the theme version in Trac, whilst style.css defines Version: 2.0.21.

[nacin]

Everything appears to be good here. What happened is the current version was 2.0.20 and then they uploaded 2.0.21. That created the initial ticket.

Before 2.0.21 was approved, 2.0.22 was uploaded. That caused the first comment, which renamed the ticket to 2.0.22 (but kept the description intact).

It's probable that the comprehensive diff from 2.0.20 to 2.0.22 should be linked from somewhere, that way a theme reviewer doesn't accidentally just review the diff from 2.0.21 to 2.0.22, ignoring the changes that occurred between 2.0.20 and 2.0.21.

Changing components as this has to do with the theme directory upload code, not Trac itself.

[nofearinc]

Thanks for the feedback nacin, that makes sense. The only problem (as you mentioned yourself) is that reviewers would see (by default) the diff with the previous uploaded version, and not previously approved (and there could be several uploads there that are not visible in the list of reviewed themes).

[obenland]

This is fixed in the new version of the uploader.
https://meta.trac.wordpress.org/browser/sites/trunk/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php#L464