Forums: Pending posts cannot be edited

[SergeyBiryukov]

Pending posts have an incorrect edit URL, which leads to a misaligned page without any form:

https://wordpress.org/support/?post_type=reply&p=8737601/edit/

See the screenshot.

[SergeyBiryukov]

@netweb: bbp_get_reply_edit_url() ​checks for pretty permalinks using bbp_use_pretty_urls(), but does not account for the fact that pending posts always have ugly permalinks. Same for bbp_get_forum_edit_url().

meta-2478.bbpress.patch​ is a patch for bbPress, and meta-2478.patch​ is a workaround we could use in the theme until the fix is deployed on the forums.

[SergeyBiryukov]

Created a ticket for meta-2478.bbpress.patch​ on bbPress Trac: ​#bb3054.

[coffee2code]

In 4892:

Support Theme: Fix edit links for pending posts.

bbPress appends '/edit/' even to ugly permalinks, which pending posts will always have.

Fixes #2478.

[SergeyBiryukov]

In 4910:

Support Theme: After [4892], adjust the workaround for pending post edit URLs to also account for %2Fedit%2F, in addition to /edit/.

The /edit/ argument is encoded if view=all was appended to the URL via bbp_add_view_all().

See #2478.