Opened 7 years ago

Closed 7 years ago

Last modified 2 years ago

#2478 closed defect (bug) (fixed)

Forums: Pending posts cannot be edited

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: coffee2code's profile coffee2code
Milestone: Priority: normal
Component: Support Forums Keywords: has-patch commit

Description (last modified by SergeyBiryukov)

Pending posts have an incorrect edit URL, which leads to a misaligned page without any form:

See the screenshot.

Attachments (3)

meta-2478.PNG (46.2 KB) - added by SergeyBiryukov 7 years ago.
meta-2478.bbpress.patch (1.0 KB) - added by SergeyBiryukov 7 years ago.
meta-2478.patch (1.1 KB) - added by SergeyBiryukov 7 years ago.

Download all attachments as: .zip

Change History (8)

#1 @SergeyBiryukov
7 years ago

  • Description modified (diff)

#2 @SergeyBiryukov
7 years ago

  • Keywords has-patch commit added

@netweb: bbp_get_reply_edit_url() checks for pretty permalinks using bbp_use_pretty_urls(), but does not account for the fact that pending posts always have ugly permalinks. Same for bbp_get_forum_edit_url().

meta-2478.bbpress.patch is a patch for bbPress, and meta-2478.patch is a workaround we could use in the theme until the fix is deployed on the forums.

#3 @SergeyBiryukov
7 years ago

Created a ticket for meta-2478.bbpress.patch on bbPress Trac: #bb3054.

#4 @coffee2code
7 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 4892:

Support Theme: Fix edit links for pending posts.

bbPress appends '/edit/' even to ugly permalinks, which pending posts will always have.

Fixes #2478.

#5 @SergeyBiryukov
7 years ago

In 4910:

Support Theme: After [4892], adjust the workaround for pending post edit URLs to also account for %2Fedit%2F, in addition to /edit/.

The /edit/ argument is encoded if view=all was appended to the URL via bbp_add_view_all().

See #2478.

Note: See TracTickets for help on using tickets.