Opened 10 years ago

Closed 10 years ago

#250 closed enhancement (fixed)

The Handbook Plugins need to be modified for devhub

Reported by: siobhan's profile siobhan Owned by: coffee2code's profile coffee2code
Milestone: Priority: normal
Component: Developer Hub Keywords:

Description (last modified by siobhan)

@nacin created a suite of plugins for the contributor handbooks. These have been modified by @krogsgard but still require some more edits. The file is here:

These need to be edited for the devhub handbooks. Specific edits are:

  1. We need two custom post types in the plugin:

Name: Theme Development Handbook
Singular Name: Theme Handbook Page
Label: Theme Handbook

Name: Plugin Development Handbook
Singular Name: Plugin Handbook Page
Label: Plugin Handbook

  1. Add different markup to the "Watch this page" functionality so that it can be styled independently.

Attachments (1) (7.4 KB) - added by siobhan 10 years ago.
First update of handbook plugin for devhub

Download all attachments as: .zip

Change History (9)

10 years ago

First update of handbook plugin for devhub

#1 @siobhan
10 years ago

  • Description modified (diff)

#2 @Rarst
10 years ago

  • Cc contact@… added

I have edited post types to these (and removed the one it has, right?).

Please elaborate on what needs to be done on second item.

#3 @nacin
10 years ago

The Handbook plugin is designed to be fairly extensible. It sounds like we can abstract the post-type-specific stuff into a single class, and then instantiate it a few times based on the different pieces of data we need.

What are the tentative URLs for these handbooks? That will help.

#4 @Rarst
10 years ago

What are still pending tasks on the plugin? What do I need to do to get it running on staging? Which would probably makes sense at this point.

#5 @Rarst
10 years ago

  • Priority changed from high to normal

#7 @coffee2code
10 years ago

In 705:

Handbook plugin: abstract post-type handling to allow for multiple post-type usage, namely for Devhub. props nicolealleyinteractivecom. See #250

#8 @coffee2code
10 years ago

  • Owner set to coffee2code
  • Resolution set to fixed
  • Status changed from new to closed

In 706:

Handbook plugin: misc fixes and tweaks. Fixes #250

  • Fix to set object post_type variable when post_type is 'handbook'
  • Fix to use get_post_type() instead of referencing no-long-existing object variable
  • Don't append suffix for 'page' post_type (for ToC and widgets)
  • Honor before_widget and after_widget config for widget
  • More succinct and thorough array typecasting
  • Internationalize strings
  • Minor spacing and code formatting tweaks
Note: See TracTickets for help on using tickets.