Making WordPress.org

Opened 4 years ago

Last modified 2 months ago

#2504 new defect

Forums: Replies from archived topics are still displayed in user profiles

Reported by: SergeyBiryukov Owned by:
Milestone: Q1 Priority: high
Component: Support Forums Keywords:


  1. Archive a topic (but not individual replies).
  2. Replies from that topic are still displayed in participants' profiles.

Change History (14)

#1 @SergeyBiryukov
4 years ago

Related: #2408 (for WP.org profiles).

#2 @SergeyBiryukov
4 years ago

It's not just archived; replies from pending and spam topics are also displayed in profiles, unless replies themselves have a non-public status too.

#3 @fierevere
3 years ago

repiles from archived topics are displayed in RSS-feeds as well, unless they are archived too

This ticket was mentioned in Slack in #forums by clorith. View the logs.

3 years ago

#5 @Clorith
3 years ago

@coffee2code might have some information on the connection between profiles and the archived states here.

#6 @tellyworth
22 months ago

  • Milestone set to Q1
  • Priority changed from normal to high

#7 @SergeyBiryukov
14 months ago

#4724 was marked as a duplicate.

#8 @Clorith
12 months ago

Thinking on this, getting the parent topic of posts and checking the parent state sounds relatively expensive, I wonder if the right approach here would be to hook into the status change and change any reply with a default state to be archived as well, we would have some floaters pre-implementation, but I think that's an acceptable tradeoff, and they can be dealt with manually if desired?

Not sure how we would solve the data that's been sent to the profiles section though, since that's technically a different system.

This ticket was mentioned in Slack in #bbpress by netweb. View the logs.

11 months ago

This ticket was mentioned in Slack in #bbpress by netweb. View the logs.

11 months ago

#11 @johnjamesjacoby
11 months ago

See: bbp_trash_topic_replies() and bbp_untrash_topic_replies()

When a Topic has some action taken on it, some other action needs to run on the children Replies.

Unfortunately, you cannot simply blindly take action on all of them, because some of them may already be trashed, and you don't want untrashing something to accidentally bring things back from the dead.

See the _bbp_pre_trashed_replies Topic meta key, as an example of this juggle. It makes sure that when a Topic is untrashed, that previously trashed Replies do not suddenly also become untrashed.

(The same happens when marking a Topic as Spam.)

My recommendation is to mirror this behavior for Topic Archives, and mark the replies as archived as well. This may require a bit of finesse, since Topics generally expect their replies to either be "public" or "non-public" by default, and Archived kinda walks the line.

#12 @dd32
9 months ago

Is this a bbPress core thing, or a weirdness due to an optimization on the WordPress.org side of things?

#13 @dd32
2 months ago

  • Milestone changed from Q1 to 2020 Q1

Milestone renamed

#14 @dd32
2 months ago

  • Milestone changed from 2020 Q1 to Q1

Milestone renamed

Note: See TracTickets for help on using tickets.