WordPress.org

Making WordPress.org

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#2513 closed defect (fixed)

"Reply and mark as resolved" now displays on Reviews

Reported by: dmchale Owned by: SergeyBiryukov
Milestone: Priority: normal
Component: Support Forums Keywords:
Cc:

Description

I wasn't sure if I should reply to a closed ticket or create a new one - hope the new one is okay.

In #2070 the "reply and mark as resolved" checkbox was re-introduced... but this seems to have now brought it back on Reviews as well as simple support forum posts. I don't believe that this checkbox belongs on Reviews since there is no "resolution" to change/apply.

Perhaps add a check to ensure that the post being replied to is NOT a Review "type"?

Change History (6)

#1 @SergeyBiryukov
2 years ago

  • Component changed from General to Support Forums

#2 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 4914:

Support Forums: Only show "Reply and mark as resolved" checkbox if Topic Resolution plugin is enabled on the current forum.

Fixes #2513.

#3 @dmchale
2 years ago

cheers @SergeyBiryukov

#4 follow-up: @dmchale
2 years ago

@SergeyBiryukov is there some type of propagation time before the earlier change will be seen in the wild? I had another review posted to one of my plugins this evening, went to look at it and noticed the "reply and mark as resolved" checkbox is still there on the screen.

#5 in reply to: ↑ 4 @SergeyBiryukov
2 years ago

Replying to dmchale:

is there some type of propagation time before the earlier change will be seen in the wild?

Yes, the change has not been deployed yet. There is also a systems issue preventing some deployments at the moment, so it might take some time.

#6 @dmchale
2 years ago

Okay no worries. Just thought I'd check back in, on the chance it was a "that patch didn't behave as expected" issue.

Note: See TracTickets for help on using tickets.