"Reply and mark as resolved" now displays on Reviews

[dmchale]

I wasn't sure if I should reply to a closed ticket or create a new one - hope the new one is okay.

In #2070 the "reply and mark as resolved" checkbox was re-introduced... but this seems to have now brought it back on Reviews as well as simple support forum posts. I don't believe that this checkbox belongs on Reviews since there is no "resolution" to change/apply.

Perhaps add a check to ensure that the post being replied to is NOT a Review "type"?

[SergeyBiryukov]

In 4914:

Support Forums: Only show "Reply and mark as resolved" checkbox if Topic Resolution plugin is enabled on the current forum.

Fixes #2513.

[dmchale]

cheers @SergeyBiryukov

[dmchale]

@SergeyBiryukov is there some type of propagation time before the earlier change will be seen in the wild? I had another review posted to one of my plugins this evening, went to look at it and noticed the "reply and mark as resolved" checkbox is still there on the screen.

[SergeyBiryukov]

Replying to dmchale:

is there some type of propagation time before the earlier change will be seen in the wild?

Yes, the change has not been deployed yet. There is also a ​systems issue preventing some deployments at the moment, so it might take some time.

[dmchale]

Okay no worries. Just thought I'd check back in, on the chance it was a "that patch didn't behave as expected" issue.