WordPress.org

Making WordPress.org

Opened 2 years ago

Closed 2 years ago

#2528 closed defect (fixed)

Support Theme: Remove indentation on first line of blockquote or fix quote mark

Reported by: zoonini Owned by: SergeyBiryukov
Milestone: Priority: normal
Component: Support Forums Keywords:
Cc:

Description

To replicate:

  • In a forum reply, use blockquote formatting on a piece of text

Result: the first line of the blockquote is indented.

https://cldup.com/EnVqQVOGtC.png

Screenshot taken at: https://wordpress.org/support/topic/front-page-images-3/#post-8836962

Expected: the first line of the blockquote should not be indented.

Digging into the CSS a bit, it looks like an opening quote symbol is supposed to be displayed in that space:

blockquote, q {
	quotes: "" "";
}
blockquote::before {
    color: #ccc;
    content: open-quote;
    font-size: 4em;
    line-height: 0;
    margin-right: 15px;
    vertical-align: -0.5em;
}

But it doesn't look like it's working as expected, and a blank space is appearing instead.

Tested in Firefox 51.0.1 and Chrome 56.0.2924.87.

Change History (3)

#2 in reply to: ↑ description @netweb
2 years ago

Replying to zoonini:

Digging into the CSS a bit, it looks like an opening quote symbol is supposed to be displayed in that space:

That's correct, here's how it works on bbPress.org: (src post)
https://cldup.com/1tlTaxe1pf.png

The source code of this CSS is via the bb-base shared theme: buddypress.org/public_html/wp-content/themes/bb-base/style.css?annotate=blame#L551:

blockquote:before {
        color: #ccc;
        content: open-quote;
        font-size: 4em;
        line-height: 0em;
        margin-right: 15px;
        vertical-align: -0.5em;
}

It is then orevridden by the content: ""; code at wordpress.org/public_html/wp-content/themes/pub/wporg-support/sass/elements/_elements.scss#L22

We could remove that override and add the open-quote also for w.org:
https://cldup.com/KHQ7lkIjtp.png

#3 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 5105:

Support Theme: Remove indentation on the first line of blockquotes.

Props zoonini, netweb.
Fixes #2528.

Note: See TracTickets for help on using tickets.