WordPress.org

Making WordPress.org

Opened 12 months ago

Closed 12 months ago

Last modified 6 months ago

#2542 closed defect (fixed)

Support Theme: Add an additional visual cue to links in posts

Reported by: anevins Owned by: SergeyBiryukov
Milestone: Priority: normal
Component: Support Forums Keywords: a11y needs-refresh
Cc:

Description

When a link is posted within a block of text that link is only distinguishable through colour. The colour contrast between the link text and paragraph text is quite subtle and so links can be difficult to spot. It may also be tricky for people with colour blindness.

Can we add a visual cue as addition to the colour to distinguish the links? Underline works, or bold text for example.

Attachments (5)

meta-2542.underline.patch (2.0 KB) - added by SergeyBiryukov 12 months ago.
meta-2542.underline.PNG (34.9 KB) - added by SergeyBiryukov 12 months ago.
meta-2542.bold.patch (2.0 KB) - added by SergeyBiryukov 12 months ago.
meta-2542.bold.PNG (35.1 KB) - added by SergeyBiryukov 12 months ago.
meta-2542.patch (5.8 KB) - added by SergeyBiryukov 12 months ago.

Download all attachments as: .zip

Change History (27)

#1 @SergeyBiryukov
12 months ago

  • Component changed from General to Support Forums
  • Summary changed from Add an additional visual cue to links in posts to Support Theme: Add an additional visual cue to links in posts

#2 @SergeyBiryukov
12 months ago

  • Keywords ui-feedback added

#3 follow-up: @SergeyBiryukov
12 months ago

@mapk: What would you prefer here?

#4 @SergeyBiryukov
12 months ago

  • Keywords has-patch added

#5 in reply to: ↑ 3 ; follow-ups: @mapk
12 months ago

Replying to SergeyBiryukov:

@mapk: What would you prefer here?

This is difficult. We don't really do this elsewhere in the Support forums do we? So do we make a new style that just affects links within comments within forum posts?

I totally agree that links aren't viewed easily in the comments. So after looking around, I found this.

https://cldup.com/U6OBNaJDRR.png

Link styles are underlined, and @ mentions are in bold... within posts. Let's go with this.

#6 in reply to: ↑ 5 @samuelsidler
12 months ago

Replying to mapk:

Link styles are underlined, and @ mentions are in bold... within posts. Let's go with this.

Fwiw, the other link in that screenshot – the tag – should probably also be bold. Worth fixing wherever that code is and standardizing everywhere.

#7 in reply to: ↑ 5 ; follow-up: @SergeyBiryukov
12 months ago

Replying to mapk:

Link styles are underlined, and @ mentions are in bold... within posts. Let's go with this.

Thanks! Mentions on the forums don't have a specific class though (unlike P2 mentions with class="mention"), so we'd need to find and adjust the code that converts them to a link to also add a class.

@samuelsidler On my local bbPress install, mentions are not linked. Could it be a dotorg-specific plugin that converts them to a link on the forums?

Last edited 12 months ago by SergeyBiryukov (previous) (diff)

#8 in reply to: ↑ 7 ; follow-up: @netweb
12 months ago

Replying to SergeyBiryukov:

@samuelsidler On my local bbPress install, mentions are not linked. Could it be a dotorg-specific plugin that converts them to a link on the forums?

bbPress links mentions "out of the box", works fine here for me:

Maybe a bbPress issue with the rexex parsing of the @s7ranger string /shrug

#9 @samuelsidler
12 months ago

Maybe. But we also have a custom plugin that could be interfering here.

@coffee2code: Can you take a look at wporg-notifications.php and see if that's related?

#10 in reply to: ↑ 8 @SergeyBiryukov
12 months ago

Replying to netweb:

bbPress links mentions "out of the box", works fine here for me

Indeed, other mentions work as expected on my install too. Thanks :)

#11 @SergeyBiryukov
12 months ago

Ah, bbp_make_mentions_clickable_callback() only works for existing users of the site, that would explain it.

#13 @SergeyBiryukov
12 months ago

  • Keywords ui-feedback removed

#14 in reply to: ↑ 12 ; follow-up: @netweb
12 months ago

Replying to SergeyBiryukov:

meta-2542.patch implements comment:5.

We should probably add a class and make bbp_make_mentions_clickable_callback() filterable in bbPress core

#15 in reply to: ↑ 14 ; follow-up: @SergeyBiryukov
12 months ago

Replying to netweb:

We should probably add a class and make bbp_make_mentions_clickable_callback() filterable in bbPress core

Sounds good :)

#16 in reply to: ↑ 15 ; follow-up: @netweb
12 months ago

Replying to SergeyBiryukov:

Replying to netweb:

We should probably add a class and make bbp_make_mentions_clickable_callback() filterable in bbPress core

Sounds good :)

I've created #bb3074 for this

#17 in reply to: ↑ 16 @netweb
12 months ago

  • Keywords needs-refresh added; has-patch removed

Replying to netweb:

Replying to SergeyBiryukov:

Replying to netweb:

We should probably add a class and make bbp_make_mentions_clickable_callback() filterable in bbPress core

Sounds good :)

I've created #bb3074 for this

Default classes and bbp_make_mentions_clickable_classes filter added in bbPress:changeset:6346

#18 @SergeyBiryukov
12 months ago

Going with meta-2542.patch for now, until bbPress is updated to 2.6 on the forums.

#19 @SergeyBiryukov
12 months ago

In 5045:

Support Forums: Add mention class to bbPress' built-in clickable user mentions for styling purposes.

See #2542.

#20 @SergeyBiryukov
12 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 5046:

Support Theme: Add a visual cue to links in post content to improve accessibility.

  • Regular links should be underlined.
  • User mentions should be in bold.

Fixes #2542.

#21 @SergeyBiryukov
12 months ago

In 5079:

Support Theme: After [5046], don't underline links in revision logs, only in actual post content.

See #2542.

#22 @SergeyBiryukov
6 months ago

In 5824:

Support Theme: After [5046], add underline to links in regular pages' content as well for better accessibility.

See #2542.

Note: See TracTickets for help on using tickets.