Support Theme: Add an additional visual cue to links in posts

[anevins]

When a link is posted within a block of text that link is only distinguishable through colour. The colour contrast between the link text and paragraph text is quite subtle and so links can be difficult to spot. It may also be tricky for people with colour blindness.

Can we add a visual cue as addition to the colour to distinguish the links? Underline works, or bold text for example.

[SergeyBiryukov]

• meta-2542.underline.patch​ adds an underline for links in post content: meta-2542.underline.PNG​.
• meta-2542.bold.patch​ makes them bold: meta-2542.bold.PNG​.

@mapk: What would you prefer here?

[mapk]

Replying to SergeyBiryukov:

• meta-2542.underline.patch​ adds an underline for links in post content: meta-2542.underline.PNG​.
• meta-2542.bold.patch​ makes them bold: meta-2542.bold.PNG​.

@mapk: What would you prefer here?

This is difficult. We don't really do this elsewhere in the Support forums do we? So do we make a new style that just affects links within comments within forum posts?

I totally agree that links aren't viewed easily in the comments. So after looking around, I found this.

Link styles are underlined, and @ mentions are in bold... within posts. Let's go with this.

[samuelsidler]

Replying to mapk:

Link styles are underlined, and @ mentions are in bold... within posts. Let's go with this.

Fwiw, the other link in that screenshot – the tag – should probably also be bold. Worth fixing wherever that code is and standardizing everywhere.

[SergeyBiryukov]

Replying to mapk:

Link styles are underlined, and @ mentions are in bold... within posts. Let's go with this.

Thanks! Mentions on the forums don't have a specific class though (unlike P2 mentions with class="mention"), so we'd need to find and adjust the code that converts them to a link.

@samuelsidler On my local bbPress install, mentions are not linked. Could it be a dotorg-specific plugin that converts them to a link on the forums?

[netweb]

Replying to SergeyBiryukov:

@samuelsidler On my local bbPress install, mentions are not linked. Could it be a dotorg-specific plugin that converts them to a link on the forums?

bbPress links mentions "out of the box", works fine here for me:

• ​https://wordpress.org/support/topic/mentions-testing/?view=all
• 

Maybe a bbPress issue with the rexex parsing of the @s7ranger string /shrug

[samuelsidler]

Maybe. But we also have a custom plugin that could be interfering here.

@coffee2code: Can you take a look at wporg-notifications.php and see if that's related?

[SergeyBiryukov]

Replying to netweb:

bbPress links mentions "out of the box", works fine here for me

Indeed, other mentions work as expected on my install too. Thanks :)

[SergeyBiryukov]

Ah, bbp_make_mentions_clickable_callback() only works for existing users of the site, that would explain it.

[SergeyBiryukov]

meta-2542.patch​ implements comment:5.

[netweb]

Replying to SergeyBiryukov:

meta-2542.patch​ implements comment:5.

We should probably add a class and make bbp_make_mentions_clickable_callback() filterable in bbPress core

[SergeyBiryukov]

Replying to netweb:

We should probably add a class and make bbp_make_mentions_clickable_callback() filterable in bbPress core

Sounds good :)

[netweb]

Replying to SergeyBiryukov:

Replying to netweb:

We should probably add a class and make bbp_make_mentions_clickable_callback() filterable in bbPress core

Sounds good :)

I've created ​#bb3074 for this

[netweb]

Replying to netweb:

Replying to SergeyBiryukov:

Replying to netweb:

We should probably add a class and make bbp_make_mentions_clickable_callback() filterable in bbPress core

Sounds good :)

I've created ​#bb3074 for this

Default classes and bbp_make_mentions_clickable_classes filter added in ​bbPress:changeset:6346

[SergeyBiryukov]

Going with meta-2542.patch​ for now, until bbPress is updated to 2.6 on the forums.

[SergeyBiryukov]

In 5045:

Support Forums: Add mention class to bbPress' built-in clickable user mentions for styling purposes.

See #2542.

[SergeyBiryukov]

In 5046:

Support Theme: Add a visual cue to links in post content to improve accessibility.

• Regular links should be underlined.
• User mentions should be in bold.

Fixes #2542.

[SergeyBiryukov]

In 5079:

Support Theme: After [5046], don't underline links in revision logs, only in actual post content.

See #2542.

[SergeyBiryukov]

In 5824:

Support Theme: After [5046], add underline to links in regular pages' content as well for better accessibility.

See #2542.