WordPress.org

Making WordPress.org

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#2574 closed defect (fixed)

Support Theme: Add styling for single page template

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: Priority: normal
Component: Support Forums Keywords: has-patch
Cc:

Description

Locales that don't have a handbook yet, but have a forum welcome page on Codex or elsewhere, might want to move it to a page on the forums site.

At the moment, the page.php template in the theme is not styled properly.

Attachments (10)

2574.png (422.8 KB) - added by ocean90 2 years ago.
2574.before.png (462.4 KB) - added by SergeyBiryukov 2 years ago.
2574.with-sidebar.png (387.7 KB) - added by SergeyBiryukov 2 years ago.
2574.without-sidebar.png (331.6 KB) - added by SergeyBiryukov 2 years ago.
2574.one-column-centered.png (533.9 KB) - added by SergeyBiryukov 2 years ago.
2574.two-columns-centered.png (625.4 KB) - added by SergeyBiryukov 2 years ago.
2574.one-column-with-sidebar.png (561.9 KB) - added by SergeyBiryukov 2 years ago.
2574.two-columns-full-width.png (589.7 KB) - added by SergeyBiryukov 2 years ago.
2574.one-template.patch (15.8 KB) - added by SergeyBiryukov 2 years ago.
2574.multiple-templates.patch (19.7 KB) - added by SergeyBiryukov 2 years ago.

Change History (24)

#1 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 5139:

Support Theme: Make single page template consistent with the rest of the forums.

Fixes #2574.

@ocean90
2 years ago

#2 follow-up: @ocean90
2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I don't think that pages should get the same sidebar as the forums. Sidebars should contain content which is related to the main content. Looking and the Italian handbook and the sidebar looks a bit off.

cc: @cristianozanca

#3 in reply to: ↑ 2 @SergeyBiryukov
2 years ago

Replying to ocean90:

I don't think that pages should get the same sidebar as the forums. Sidebars should contain content which is related to the main content. Looking and the Italian handbook and the sidebar looks a bit off.

We'd need a separate template for the handbook, I guess.

I was thinking of regular pages like https://ru.wordpress.org/support/forum-rules/, which should still have a sidebar, and the one from the forums fits there well.

#4 @ocean90
2 years ago

In this case I suggest that the default page.php is full-width like before and a new page template is added which provides the sidebar from the forums.

#5 @SergeyBiryukov
2 years ago

Yep, I've just noticed that https://it.wordpress.org/support/handbook/ is a regular page too, not the handbook plugin.

I agree, will do the changes shortly :)

#6 @SergeyBiryukov
2 years ago

In 5141:

Support Theme: After [5139], remove the sidebar from default page.php template.

Introduce a new page-forums-sidebar.php template for a page with a sidebar from forums.

See #2574.

#7 @cristiano.zanca
2 years ago

Yep @SergeyBiryukov translating handbook we made a regular page formatting that works with our old locale theme, now should be great to work with a

new page template which provides the sidebar from the forums

as suggested by @ocean90 :)

#8 follow-up: @samuelsidler
2 years ago

Fwiw, I don't think pages in the support forum should have a sidebar. We discussed (but did not implement apparently) using the same design as this page from the new plugin directory. I know @mapk has opinions on this.

#9 in reply to: ↑ 8 ; follow-up: @SergeyBiryukov
2 years ago

Replying to samuelsidler:

Fwiw, I don't think pages in the support forum should have a sidebar. We discussed (but did not implement apparently) using the same design as this page from the new plugin directory.

Thanks, I see now. It looked somewhat similar to that page, but without page title and in full width: 2574.before.png.

That didn't look consistent with the rest of the forums, also taking into account the font size difference, so I suspected that something's off, but didn't know how exactly it's supposed to look.

I had some other thoughts:

  • "My Account" should be consistently displayed across the site rather than come and go on different pages.
  • Same with breadcrumbs.
  • Having common views on pages might encourage users to take a look at other topics and maybe provide some help there while waiting for a reply.
  • In full width, current template looks better with a sidebar than as a wall of text: 2574.with-sidebar.png vs. 2574.without-sidebar.png.

That said, I can remove the new template and make pages look like https://wordpress.org/plugins-wp/developers/ (restore larger font size, remove breadcrumbs, add left and right margin), if that would be a consensus here.

#10 in reply to: ↑ 9 ; follow-up: @mapk
2 years ago

Replying to SergeyBiryukov:

That said, I can remove the new template and make pages look like https://wordpress.org/plugins-wp/developers/ (restore larger font size, remove breadcrumbs, add left and right margin), if that would be a consensus here.

That sounds right, Sergey.

#11 in reply to: ↑ 10 @SergeyBiryukov
2 years ago

  • Keywords has-patch added

Replying to mapk:

That sounds right, Sergey.

Thanks for the feedback!

2574.one-template.patch implements comment:10. Seems to work for simple one-column content, but a more complex page gets shifted to the right, because narrow layout doesn't really allow for any kind of in-page navigation, and it looks a bit weird when that navigation starts in the middle of the screen.

I'd still like to have some flexibility here:

  • Not every support page can be trimmed down to a single column without a navigation.
  • Some pages make more sense as a part of the forums layout and navigation rather than standalone content.
  • Some content doesn't fit well in a narrow column.

It would probably help if we could create custom menus on forum pages, but there's no such option at the moment.

For now, could we have three page templates to address the most popular use cases? They'll have the same font size and style, just different layout:

  1. Default page.php template for simple one-column content: 2574.one-column-centered.png.
  2. A template with a forums sidebar for forum-related pages: 2574.one-column-with-sidebar.png.
  3. A full-width template for wider content with navigation, e.g. handbooks: 2574.two-columns-full-width.png.

2574.multiple-templates.patch implements that. Any objections?

#12 @cristiano.zanca
2 years ago

I totally agree with @SergeyBiryukov :"

It would probably help if we could create custom menus on forum pages

The old Welcome Support Forum page https://codex.wordpress.org/it:Benvenuto_nel_Forum#Prodotti_a_pagamento has a useful sidebar that we are going to write bespoke to relative link inside the document to reach them better.
http://i.imgur.com/WAhEcVQ.png



this is the new page where the old little dx sidebar could be mantained:


http://i.imgur.com/aPGkPsB.png

#13 @SergeyBiryukov
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 5382:

Support Theme: Provide more flexibility in page templates:

  • Use default page.php template for simple one-column content.
  • Keep page-forums-sidebar.php template for forum-related pages.
  • Add page-full-width.php template for wider content with in-page navigation.

Fixes #2574.

#14 @SergeyBiryukov
2 years ago

In 5386:

Support Theme: Use correct text domain for strings in template-parts/content-page.php.

See #2574.

Note: See TracTickets for help on using tickets.