Codex: #dotorgredirect does not redirect to Rosetta sites

[SergeyBiryukov]

I'm trying to redirect an old ​"Forum rules" page on Codex to a ​new page on the forums.

The #dotorgredirect directive is used for redirecting pages to developer.w.org, so I thought this would work:

{{#dotorgredirect:https://ru.wordpress.org/support/forum-rules/}}

However, it just displays "Invalid Redirect" on the page.

Is there a whitelist in the redirect script? Could we add forums to that list?

[samuelsidler]

This is based on a whitelist. @Otto42 should be able to help here.

[dd32]

Just to note, the plugin only allows redirects to the following hostnames:

• developer.wordpress.org
• make.wordpress.org

I don't see any harm in allowing *.wordpress.org / wordpress.org myself though.
Any thoughts from anyone as to why it's as it is? @otto42?

[Otto42]

I wrote it that way because that's the way I was told to write it. No other reason. It was originally intended only for redirection of moved documentation. It can be expanded in scope if needed.

[SergeyBiryukov]

Replying to Otto42:

It was originally intended only for redirection of moved documentation. It can be expanded in scope if needed.

With the ​Systems request deployed, I thought a redirect to https://ru.wordpress.org/support/forum-rules/ would now work, but still getting an "Invalid Redirect" error.

Apparently Rosetta domains like *.wordpress.org are still not whitelisted, only the main domain is?

[dd32]

Replying to SergeyBiryukov:

Replying to Otto42:

It was originally intended only for redirection of moved documentation. It can be expanded in scope if needed.

With the ​Systems request deployed, I thought a redirect to https://ru.wordpress.org/support/forum-rules/ would now work, but still getting an "Invalid Redirect" error.

Apparently Rosetta domains like *.wordpress.org are still not whitelisted, only the main domain is?

Correct. Only wordpress.org was added.

[SergeyBiryukov]

Replying to dd32:

Correct. Only wordpress.org was added.

Thanks! While we're at it, could we add *.wordpress.org then? I tried looking into it myself, but apparently the plugin is not in the dotorg repo.

[SergeyBiryukov]

Related: #4487

[Otto42]

Okay, I added wordpress.org in deploy:8223 but forgot about *.wordpress.org. I'll make that change shortly too.

[Otto42]

Change made to deploy revision 8740. It will accept wordpress.org and *.wordpress.org. It was also send 301's for the redirects instead of 302's.

[SergeyBiryukov]

Replying to Otto42:

Change made to deploy revision 8740. It will accept wordpress.org and *.wordpress.org.

Thanks! Is it deployed yet? Still getting "Invalid Redirect" for this:

{{#dotorgredirect:https://ru.wordpress.org/support/forum-rules/}}

[dd32]

Replying to SergeyBiryukov:

{{#dotorgredirect:https://ru.wordpress.org/support/forum-rules/}}

This seems to be working for me now.

[SergeyBiryukov]

Replying to dd32:

This seems to be working for me now.

Indeed, now works for me too :)