Making WordPress.org

Opened 8 years ago

Closed 6 years ago

#2581 closed defect (bug) (wontfix)

Something interfering with browser "Find in page"

Reported by: joyously's profile joyously Owned by:
Milestone: Priority: normal
Component: Handbooks Keywords:
Cc:

Description

It seems like there is javascript capturing what I type, and putting most of it in the Search box.
I use the "search in page" feature of my browser a lot, which means I start typing on a page and the browser finds that text in the page. Trying to use that in a Handbook page often doesn't work, because (it looks like) a script is taking what I type and putting it in the Search box, missing the first letter. I don't want to search the Handbook, I want to search in the current page!

It could be that the script is changing the focus for me. I am careful to click in a neutral part of the page and then type. Sometimes my browser gets my keystrokes and searches, but mostly the focus goes to the search box and what I type ends up in there. It's inconsistent and very annoying.

Change History (5)

#1 follow-up: @samuelsidler
8 years ago

The o2 Breathe theme includes keyboard commands by default, which could be interfering with your search. It sounds like you're using Firefox as I can't think of another browser that offers find-as-you-type-style search. I recommend using / at the start of your search query.

#2 in reply to: ↑ 1 @SergeyBiryukov
8 years ago

Replying to samuelsidler:

I recommend using / at the start of your search query.

Just tested on https://make.wordpress.org/polyglots/handbook/ with Opera, it does jump to the search box when I type s. It does the same when I type / though, not sure if that's expected.

#3 follow-up: @joyously
8 years ago

Is o2 Breathe used only on the Handbooks? I wasn't having this trouble on other .org pages, just Handbook pages.

#4 in reply to: ↑ 3 @SergeyBiryukov
8 years ago

Replying to joyously:

Is o2 Breathe used only on the Handbooks? I wasn't having this trouble on other .org pages, just Handbook pages.

It's also used on Make blogs, e.g. https://make.wordpress.org/core/ or https://make.wordpress.org/polyglots/.

#5 @coffee2code
6 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

As Sergey notes, o2 is used on the Make sites, including their handbooks. The theme has a number of keyboard shortcuts which, naturally, would interfere with and justifiably take precedence over any browser-based keyboard shortcuts.

Closing as wontfix as the current behavior is intentional, unfocused keypress binding doesn't seem to be a pervasive browser feature, and there have been no additional reports in the 2 years since this was reported.

Note: See TracTickets for help on using tickets.