API is returning a different author name than the plugin directory

[ocean90]

The API seems to return a different author name as the previous API and the front end of the new plugin directory.

​https://wordpress.org/plugins-wp/public-post-preview/

[ocean90]

Already chatted with @dd32 about this. He'll take a look at this.

[hallsofmontezuma]

On the "View details" link in plugins.php, in addition to the author being wrong (it's the original submitter of the plugin rather than the current author) the link also goes to the wrong website.

It's also incorrect on plugin-install.php, but presumably that info comes from the same place.

Interestingly, at ​https://api.wordpress.org/plugins/info/1.0/simplemap/, the author URL is correct, and the author name, but not the author profile.

[hallsofmontezuma]

plugins.php

[hallsofmontezuma]

plugin api

[hallsofmontezuma]

plugin install

[Otto42]

Related: #2630

[Otto42]

#2640 was marked as a duplicate.

[obenland]

@dd32 Is this the right place to fix it?

[dd32]

@obenland Looks good to me - I haven't tested it though, verify that it looks good in https://wordpress.org/plugins/wp-json/plugins/v1/plugin/$slug and commit - the caches in the API are ~24hrs though, but any commit or change to an affected plugin will cause that to be cleared.

[Otto42]

Might want to add esc_url on it if core doesn't, but other than that, patch looks good.

[dd32]

In 5204:

Plugin Directory: Use the Author and Author URI plugin headers in the API response instead of the original plugin submitters details.
This doesn't change author_profile which still references the original uploaders profile, as it always has. This field doesn't appear to be used by WordPress though.

Props obenland for initial patch.
Fixes #2585.

[progmastery]

Related: #2647