Enhance compatibility with per forum moderators

[ocean90]

bbPress 2.6 ​supports per forum moderators. This is handled in bbp_map_primary_meta_caps(). But the ​additional checks are not done if no post ID is passed to the WP_User::has_cap() check.

• In Topic_Resolution\Plugin::user_can_resolve() we can use the existing $topic_id variable.
• In User_Badges\Plugin::is_user_moderator() using get_queried_object_id() seems to work.
• Also affected: Stickies_Compat and user flagging in User_Moderation.

Noticed this while checking how this actually works because @danielbachhuber ​requested this.

[SergeyBiryukov]

In User_Badges\Plugin::is_user_moderator() using get_queried_object_id() seems to work.

It doesn't in moderator views, e.g. 'Archived'. get_the_ID() works though.

On a related note, bbp_get_reply_author_id() should be replaced with get_post_field( 'post_author' ) there, since the function runs for both topics and replies. bbp_get_reply_author_id() falls back to the ​same line for topics (with $reply_id = 0), so this seems more straightforward.

Also affected: Stickies_Compat and user flagging in User_Moderation.

2590.2.diff​ handles some more affected instances in Moderators class and wporg-support theme.

Not sure about user flagging though, I think only global moderators should be able to flag users.

Note: The change in wporg_support_add_moderation_notice() (wporg-support/functions.php) is unnecessary at the moment, since per-forum moderators never see that notice:

• Spam/Pending/Archived views are only available to global moderators.
• ​bbp_get_topic_replies_link() doesn't show (+X hidden) link.​edit_others_replies' is mapped to 'moderate, but the check doesn't account for per-forum moderators.
• ​bbp_get_view_all() doesn't account for per-forum moderators.

The latter two points seem worth fixing though, so I kept that change in the patch, but I guess it can be committed separately later.

[macmanx]

Yes, it would be best if actions that had a global effect, like flagging, were limited to global moderators. Thanks!

[SergeyBiryukov]

In 5294:

Support Forums: Use post-specific moderate capability checks in Moderators::archive_handler() and ::get_archive_link().

See #2590.

[SergeyBiryukov]

In 5295:

Support Forums: Support Forums: Use post-specific moderate capability check in Stickies_Compat::user_can_stick().

See #2590.

[SergeyBiryukov]

In 5296:

Support Theme: Use post-specific moderate capability checks in wporg_support_add_moderation_notice() and bbpress/form-topic.php.

See #2590.

[SergeyBiryukov]

Committed everything I could, refreshed the rest in 2590.3.diff​.

[SergeyBiryukov]

@ocean90: Anything I can do to help move 2590.3.diff​ forward?

[ocean90]

In 5523:

Support Forums: Pass post IDs to moderate capability checks.

Props SergeyBiryukov.
Fixes #2590.