#2628 closed defect (bug) (fixed)
Plugin Directory: Too short plugin description with letter count locale
Reported by: | mayukojpn | Owned by: | obenland |
---|---|---|---|
Milestone: | Plugin Directory v3.0 | Priority: | normal |
Component: | Plugin Directory | Keywords: | has-patch commit |
Cc: |
Description
I found new ja
localized plugin directory has too short plugin description in a front page / archives. It might come from letter count system instead of word count.
Attachments (3)
Change History (17)
This ticket was mentioned in Slack in #polyglots by mayuko. View the logs.
7 years ago
#3
in reply to:
↑ 2
;
follow-up:
↓ 5
@
7 years ago
Replying to afzalmultani:
Hey, let's make separate ticket for different problem 😄 Are you going to make it or @petya?
#5
in reply to:
↑ 3
@
7 years ago
Replying to mayukojpn:
Replying to afzalmultani:
Hey, let's make separate ticket for different problem 😄 Are you going to make it or @petya?
okey i'm created ticket #2629
#6
@
7 years ago
- Summary changed from Too short plugin description with letter count locale to Plugin Directory: Too short plugin description with letter count locale
#7
@
7 years ago
- Keywords close added
The excerpt is very short because there is only room for three short lines. It uses `wp_trim_words()` which is supposed to account for letter count locales
#8
follow-up:
↓ 10
@
7 years ago
- Keywords needs-patch added; close removed
wporg-plugins
theme is supposed to limit the excerpt length to 15 words, see the excerpt_length() function.
In Japanese and Chinese (and perhaps other East Asian locales), wp_trim_words()
counts characters instead of words.
Seems like the limit should be increased for those locales. If the current UI can account for three lines, there's no need to overzealously limit the excerpt to just 15 characters.
#10
in reply to:
↑ 8
@
7 years ago
Replying to SergeyBiryukov:
Seems like the limit should be increased for those locales.
2628.patch implements that, using the same approach as in WordPress core.
#11
@
7 years ago
- Owner set to obenland
- Resolution set to fixed
- Status changed from new to closed
In 5196:
#12
@
7 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
@obenland: Sorry, missed text domain in my initial patch, see 2628.2.patch.
[5196] should still work, as it would use the core translation, but we should still add the text domain for clarity and best practices.
Can we change the link text that currently says "Translation Contributors"? It leads to the translation stats and doesn't immediately show contributors?