Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#2635 closed defect (bug) (fixed)

Plugin Directory: Plugins reopen immediately after code checkin

Reported by: ipstenu's profile Ipstenu Owned by: dd32's profile dd32
Milestone: Plugin Directory v3.0 Priority: highest omg bbq
Component: Plugin Directory Keywords:


When plugins are closed for security, we review them before reopening to make sure everything is okay. Right now, the plugin reopens right away when the code is committed. This is a security risk as not everyone gets it right the first time :(

I suspect it's related to opening the plugin on commit for NEW plugins. We should have a check in there to make sure the plugin is NOT set as closed to disable the auto-open.

Change History (5)

#1 @obenland
7 years ago

  • Owner set to obenland
  • Status changed from new to accepted

#2 @obenland
7 years ago

  • Owner obenland deleted
  • Status changed from accepted to assigned

I think I'll let @dd32 handle this one as well. Seems like importing from svn still relies on bbPress statuses and he's way more familiar with the importer than I am

This ticket was mentioned in Slack in #meta by tellyworth. View the logs.

7 years ago

#4 @dd32
7 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from assigned to closed

In 5200:

Plugin Directory: Remove the import-from-bbPress code for statuses & plugin posts.
This caused a plugin which had been marked as closed after the directory launch to have it's status set back to publish, this happened as it pulled the previous status from bbPress over.
The only status change which should happen post-commit is the approvad -> published change, which is now handled here.

Fixes #2635

#5 @dd32
7 years ago

In 5201:

Plugin Directory: Remove a stray extra conditional after r5200.
See #2635

Note: See TracTickets for help on using tickets.