Opened 7 years ago

Closed 7 years ago

#2665 closed enhancement (wontfix)

Plugin Directory Admins: Contact Plugin Author should open in new window

Reported by: ipstenu's profile Ipstenu Owned by: otto42's profile Otto42
Milestone: Priority: normal
Component: Plugin Directory Keywords: has-patch commit


#1690 is not working anymore.

It doesn't fill in the email address nor the subject. This is not critical, as we can copy/paste emails :D

Attachments (1)

2665.patch (1.1 KB) - added by SergeyBiryukov 7 years ago.

Download all attachments as: .zip

Change History (8)

#1 @Ipstenu
7 years ago

Update: Works on Chrome but NOT on Safari. o.O

#2 @Otto42
7 years ago

  • Owner set to Otto42
  • Status changed from new to assigned

Actually, it appears to work in Chrome, so I'll take a look at it. Also it would be nice if it opened in a new tab instead of the current one.

#3 @Ipstenu
7 years ago

  • Summary changed from Plugin Directory Admins: Contact Plugin Author Doesn't use Email to Plugin Directory Admins: Contact Plugin Author should open in new window
  • Type changed from defect to enhancement

Further testing. This works once I rebooted everything so it was a my-computer glitch there. But. You can't open in a new window, which is annoying. Can be fixed WAY later. We may just need a Support Press plugin down the road.

7 years ago

#4 @SergeyBiryukov
7 years ago

  • Keywords has-patch commit added

TIL forms have a target attribute too :)

#5 @Otto42
7 years ago

Adblock doesn't like it. I'll look into it, it's not a blocker for now.

#6 @SergeyBiryukov
7 years ago

FWIW, just tested in Chrome with AdBlock on Windows 10, opening the form in a new tab seems to work as expected, though for me it just redirects to SupportPress login form.

WordPress core uses a similar approach for the Preview button, although it sets the attribute with JS, but I guess it shouldn't matter.

#7 @Ipstenu
7 years ago

  • Resolution set to wontfix
  • Status changed from assigned to closed

On review and having used the directory for a month now, I classify this as won't fix. We don't actually need it. I was wrong :)

Note: See TracTickets for help on using tickets.