Plugin Directory Admin: Replies to internal notes have the wrong comment type

[ocean90]

WordPressdotorg\Plugin_Directory\Admin\Customizations::save_custom_comment() (or wp_ajax_replyto_comment() sets the type if $_POST['comment_type'] is set but wp_comment_reply() doesn't define a comment_type field.

To make it work on edit.php and edit-comments.php we could add a check to preprocess_comment which sets comment_type if $commentdata['comment_parent'] is an ID for an internal note.

[SergeyBiryukov]

There's a code to add the comment_type field in js/edit-form.js, but it doesn't account for replies, and it adds duplicate fields when clicking the "Add note" button several times.

2668.patch​ fixes both issues.

[SergeyBiryukov]

To make it work on edit.php and edit-comments.php we could add a check to preprocess_comment which sets comment_type if $commentdata['comment_parent'] is an ID for an internal note.

I think we could just inherit comment type from parent comment in ::save_custom_comment(), see 2668.2.patch​ (also includes the patch from #2667).

[SergeyBiryukov]

Refreshed after [5308].

[coffee2code]

In 5335:

Plugin Directory: Ensure replies to internal notes are assigned the proper comment_type when made outside of the edit plugin page.

Props SergeyBiryukov.
Fixes #2668.