WordPress.org

Making WordPress.org

Opened 9 months ago

Closed 5 months ago

#2677 closed enhancement (fixed)

Plugin Directory: Admin email subjects to plugin author (s) improvements

Reported by: Ipstenu Owned by: tellyworth
Milestone: Plugin Directory v3.0 Priority: normal
Component: Plugin Directory Keywords: has-patch commit
Cc:

Description

On the admin edit page for plugins, we generally have two reasons to email them.

1) It's a new submission with issues
2) It's an existing plugin with issues

In the first case, the email subject should be [WordPress Plugin Directory] Request: my-plugin-slug and only the person who submitted the plugin should be emailed.

In the second, however, we should email ALL users with commit access. That way if someone's added on a developer, they get the right notice. Also the email subject should be [WordPress Plugin Directory] Notice: My Plugin Name

Attached is a patch that fixes the email subject.

Attachments (5)

2677.diff (6.4 KB) - added by Ipstenu 9 months ago.
Correct email based on post status
2677.1.diff (1.5 KB) - added by Ipstenu 9 months ago.
Corrected patch
2677.2.diff (1.8 KB) - added by SergeyBiryukov 8 months ago.
2677.3.diff (2.0 KB) - added by Ipstenu 7 months ago.
Fixes translatability and adds in rejection header.
2677.4.diff (2.5 KB) - added by SergeyBiryukov 7 months ago.

Download all attachments as: .zip

Change History (12)

@Ipstenu
9 months ago

Correct email based on post status

@Ipstenu
9 months ago

Corrected patch

#1 @Ipstenu
9 months ago

Please review 2677.1.diff

I uploaded a wrong file. It's early.

#2 @tellyworth
8 months ago

  • Owner set to tellyworth
  • Resolution set to fixed
  • Status changed from new to closed

In 5267:

Plugin directory admin: improve email subject when contacting a plugin author. Props @ipstenu.

Fixes #2677

#3 @SergeyBiryukov
8 months ago

  • Keywords has-patch commit added
  • Resolution fixed deleted
  • Status changed from closed to reopened

The subject string should either be fully translatable or fully hardcoded in English, not a mix of both.

@Ipstenu
7 months ago

Fixes translatability and adds in rejection header.

#4 @Ipstenu
7 months ago

  • Summary changed from Plugin Directory: Admin email to plugin author (s) improvements to Plugin Directory: Admin email subjects to plugin author (s) improvements

Agree with Sergey! Attached patch that also adds in a subject for rejected plugins so it's more clear there too.

#5 @SergeyBiryukov
7 months ago

  • Milestone set to Plugin Directory v3.0

2677.4.diff switches to Yoda conditions, as per WP coding standards and for consistency with the check a few lines above.

Moving to v3.0, as the ticket already has a commit that just needs a follow-up.

This ticket was mentioned in Slack in #meta by ipstenu. View the logs.


6 months ago

#7 @coffee2code
5 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 5707:

Plugin Directory: Add custom email subject for rejections and improve translatability of email subjects.

Props Ipstenu, SergeyBiryukov.
Fixes #2677.

Note: See TracTickets for help on using tickets.